Remember previous URL when reloading app

[alxndrsn]

medic/cht-core#4492 (comment)

Value can probably be saved in onStop(), and restored as currently done in onCreate().

[mrsarm]

Ready for AT, PR #210 , branch mrsarm:gopinath/medic_changes (from external repo).

The feature was added as requested: remember the last URL loaded, but we also added a 24 hs limit, after that the app is loaded as always.

Worth to take into account:

• Using local environment without changing sessions TTL will cause that after 24 hs (or faking the clock) sessions being closed, so use a dev environment with longer session TTL when testing.
• Some times when you force close the app and open it again, the session is logged out, redirecting you to the login page. Not sure if it's an issue that we should report and handle in another ticket, but it is a behavior previous to this work (you can reproduce it with the latest stable version of the app).
• We added an e2e test for this feature that is executed in CI 😄 , you can see a video in a comment in the PR.

[ngaruko]

Tested with local install of cht-android from the branch.

remember.mov

Some times when you force close the app and open it again, the session is logged out, redirecting you to the login page. Not sure if it's an issue that we should report and handle in another ticket, but it is a behavior previous to this work (you can reproduce it with the latest stable version of the app).

This needs some further investigation @mrsarm . Can you please open another ticket for it with replication steps? Thanks

Otherwise, good to merge...and thank you for adding some test for this.

[garethbowen]

@ngaruko I think the logout issue may be unrelated. @dianabarsan was looking in to this...

[dianabarsan]

@ngaruko this is what I am seeing: medic/cht-core#7343 (comment)

My conclusion is that Android calls a method that persists all cookies (including session cookies) on disk on a schedule (used to be manual in previous versions: https://developer.android.com/reference/android/webkit/CookieSyncManager). If you're quicker and you kill the app before the cookies are saved, you load the "old" cookies when you restart the app.

I think we should investigate if it's possible to reduce the interval at which this method runs, or call the "flush" method ourselves, because it's very easily outperformed by a human.
From the android docs:

The WebView now automatically syncs cookies as necessary. You no longer need to create or use the CookieSyncManager. To manually force a sync you can use the CookieManager method CookieManager#flush which is a synchronous replacement for sync().

[mrsarm]

Clossing the issue (I'll create a separated ticket for the issue discussed about tomorrow).