Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task generation fails when given contactless reports #325

Closed
garethbowen opened this issue May 12, 2020 · 4 comments
Closed

Task generation fails when given contactless reports #325

garethbowen opened this issue May 12, 2020 · 4 comments
Assignees
Labels
Priority: 1 - High Blocks release eg supports new webapp feature Type: Bug Fix something that isn't working as intended
Projects

Comments

@garethbowen
Copy link
Member

To reproduce

  1. Upload declarative configuration with a task that has appliesToType defined
  2. Create a report that doesn't have an associated person or place
  3. Load the tasks tab
  4. Error loading tasks
inbox.js?_sw-precache=efde4a014d3edf17f489717a82f889b2:3 Error getting tasks for all contacts TypeError: Cannot read property 'type' of undefined
    at i (eval at <anonymous> (inbox.js?_sw-precache=efde4a014d3edf17f489717a82f889b2:3), <anonymous>:5:15288)
    at e.exports (eval at <anonymous> (inbox.js?_sw-precache=efde4a014d3edf17f489717a82f889b2:3), <anonymous>:5:17014)
    at Object.eval (eval at <anonymous> (inbox.js?_sw-precache=efde4a014d3edf17f489717a82f889b2:3), <anonymous>:5:6054)
    at n (eval at <anonymous> (inbox.js?_sw-precache=efde4a014d3edf17f489717a82f889b2:3), <anonymous>:5:397)
    at eval (eval at <anonymous> (inbox.js?_sw-precache=efde4a014d3edf17f489717a82f889b2:3), <anonymous>:5:1189)
    at n.anonymous (eval at <anonymous> (inbox.js?_sw-precache=efde4a014d3edf17f489717a82f889b2:3), <anonymous>:5:1198)
    at n.fire (inbox.js?_sw-precache=efde4a014d3edf17f489717a82f889b2:3)
    at n.fireNext (inbox.js?_sw-precache=efde4a014d3edf17f489717a82f889b2:3)
    at n.callNext (inbox.js?_sw-precache=efde4a014d3edf17f489717a82f889b2:3)
    at u (inbox.js?_sw-precache=efde4a014d3edf17f489717a82f889b2:3)

This is a supported use case and elsewhere in the code we handle it gracefully.

@garethbowen garethbowen added Type: Bug Fix something that isn't working as intended Priority: 1 - High Blocks release eg supports new webapp feature labels May 12, 2020
@garethbowen garethbowen self-assigned this May 12, 2020
@garethbowen garethbowen added this to In progress in 3.9.0 May 12, 2020
@dianabarsan
Copy link
Member

Ready for AT on 325-handle-unknown-contact

@dianabarsan dianabarsan moved this from In progress to In AT in 3.9.0 May 13, 2020
@newtewt newtewt self-assigned this May 13, 2020
@kennsippell
Copy link
Member

kennsippell commented May 15, 2020

Any chance we can publish this as medic-conf@3.2.1 once ATed and merged? This has affected some config testing for MUSO but only for some users -- I'd hate this to slip into production.

@newtewt
Copy link
Contributor

newtewt commented May 15, 2020

This is working now with contactless reports. Feel free to close and merge @garethbowen

3.9.0 automation moved this from In AT to Done May 17, 2020
@garethbowen
Copy link
Member Author

@kennsippell Agreed. I'll work on a release this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1 - High Blocks release eg supports new webapp feature Type: Bug Fix something that isn't working as intended
Projects
No open projects
3.9.0
  
Done
Development

No branches or pull requests

4 participants