Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emoji not displayed properly #55

Closed
abbyad opened this issue Jan 31, 2018 · 4 comments
Closed

Emoji not displayed properly #55

abbyad opened this issue Jan 31, 2018 · 4 comments

Comments

@abbyad
Copy link
Contributor

abbyad commented Jan 31, 2018

...on Windows

C:\Users\Marc\Documents\GitHub\medic-projects\standard>medic-conf --instance [REDACTED] upload-app-forms
­ƒöæ  Password: ********************************

I haven't found a way to enable better character support (without changing OS), so anyone on Windows configuring our instances will encounter this.
@alxndrsn
Copy link
Contributor

Does your console support emojis at all?

@alxndrsn
Copy link
Contributor

alxndrsn commented Feb 6, 2018

Not planning to fix this, sorry 😢

@alxndrsn alxndrsn closed this as completed Feb 6, 2018
@abbyad
Copy link
Contributor Author

abbyad commented Feb 28, 2018

No, Windows does not yet support emoji in any of the shells. Given that we have Windows users for this tool we should remove emoji when Windows is detected, or not use emoji for this tool. The added benefit of seeing a key emoji is not worth falling back to ­ƒöæ.

@abbyad abbyad reopened this Feb 28, 2018
alxndrsn added a commit that referenced this issue Feb 28, 2018
@alxndrsn
Fix emoji support in windows
c8d4c8f 
Issue: #55
alxndrsn added a commit that referenced this issue Feb 28, 2018
@alxndrsn
Fix emoji support in windows
f1fdef3 
Issue: #55
@alxndrsn
Copy link
Contributor

Fixed in 1.11.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alxndrsn @abbyad