Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing add contact from LHS goes to CHW area on RHS on mobile #4444

Closed
SCdF opened this issue Apr 17, 2018 · 10 comments
Closed

Closing add contact from LHS goes to CHW area on RHS on mobile #4444

SCdF opened this issue Apr 17, 2018 · 10 comments
Assignees
Labels
Priority: 3 - Low Can be bumped from the release Type: Bug Fix something that isn't working as intended
Projects

Comments

@SCdF
Copy link
Contributor

SCdF commented Apr 17, 2018

2.13.x, a CHW on mobile, LGU configuration.

Replicate:

  • Go to people list
  • Tap add family
  • Once the add family form as loaded tap the X
  • Note that it's really trying to load something
  • Note that now your area that was loading, not the default search, which is really weird and wrong

What should have happened is the contact list should have loaded again.

@SCdF SCdF added the Status: Blocked waiting for triage Blocked waiting for prioritisation label Apr 17, 2018
@sglangevin
Copy link

This is a long-time existing issue. My vote is to leave it and fix it when we do the nav update.

@SCdF
Copy link
Contributor Author

SCdF commented Apr 25, 2018

@sglangevin can I argue for doing it or #4445 sooner? When you combine this with #4445 it means that backing out of a form that you entered via the people tab takes minutes to complete (on a phone), and there is no UI that lets you navigate anywhere else (you only see a throbber).

@sglangevin
Copy link

That's a good point - I'd rather do #4445 as that seems to be a more important issue in terms of the user experience. However, we could also just do whichever one is easier. Have you investigated to see which one is simpler?

@SCdF
Copy link
Contributor Author

SCdF commented Apr 25, 2018

I haven't looked into it, I imagine neither of them should be that challenging. Presumably for #4445 we'd change it to load 10 families with a load more button that loads the rest

@sglangevin
Copy link

Adding some sort of button would involve us having to change the design of the page. Perhaps it's better to do this issue instead so that we don't land back on the CHW area page.

@medic-bot medic-bot added the Status: Blocked waiting for triage Blocked waiting for prioritisation label May 23, 2018
@medic-bot
Copy link

Hi @rmhowe,

Please ensure this ticket has a Priority, Status and Type label.

(See triaging old issues for more detail)

@rmhowe
Copy link
Contributor

rmhowe commented Jun 1, 2018

@SCdF @sglangevin looks like this has roughly ended up in the timeline to go in with the nav update anyway, put it in 3.1?

@SCdF
Copy link
Contributor Author

SCdF commented Jun 1, 2018

Worst case we should definitely make sure this is done in 3.1.

BUT, due to the performance issues noted here #4444 (comment) I'd really like us to fix it or the other ticket before then. I have no idea if people encounter this in production much but if they do it's hella terrible.

@rmhowe
Copy link
Contributor

rmhowe commented Jun 4, 2018

It looks like #4445 is the bigger issue here so I'd say that one should be fixed first, then this issue becomes a minor UI bug for 3.1

@rmhowe rmhowe added Type: Bug Fix something that isn't working as intended Status: 1 - Triaged Priority: 3 - Low Can be bumped from the release and removed Status: Blocked waiting for triage Blocked waiting for prioritisation labels Jun 4, 2018
@rmhowe rmhowe removed their assignment Jun 4, 2018
@sglangevin sglangevin added this to Bugs in 3.1.0 Jun 27, 2018
@sglangevin sglangevin moved this from Bugs to To do in 3.1.0 Jul 5, 2018
@dianabarsan dianabarsan self-assigned this Jul 23, 2018
@dianabarsan dianabarsan moved this from To do to In progress in 3.1.0 Jul 23, 2018
dianabarsan added a commit that referenced this issue Jul 26, 2018
Adds a new route query parameter to contacts.addChild to identify actions that originated in the contacts list. If such a form is canceled, the user is redirected to contacts list instead of parent contact.

#4444
@dianabarsan dianabarsan removed their assignment Jul 26, 2018
@dianabarsan dianabarsan moved this from In progress to Acceptance Testing in 3.1.0 Jul 26, 2018
@ngaruko ngaruko self-assigned this Aug 13, 2018
@ngaruko
Copy link
Contributor

ngaruko commented Oct 9, 2018

LGTM. Tested on gamma.dev... v3.1.0

@ngaruko ngaruko closed this as completed Oct 9, 2018
3.1.0 automation moved this from Acceptance Testing to Ready Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 3 - Low Can be bumped from the release Type: Bug Fix something that isn't working as intended
Projects
No open projects
3.1.0
  
Ready
Development

No branches or pull requests

6 participants