Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subject summaries are loaded one at a time #4669

Closed
garethbowen opened this issue Jun 26, 2018 · 2 comments
Closed

Subject summaries are loaded one at a time #4669

garethbowen opened this issue Jun 26, 2018 · 2 comments
Assignees
Labels
Priority: 2 - Medium Normal priority Type: Performance Make something faster
Projects

Comments

@garethbowen
Copy link
Member

In the GetSubjectSummaries service we loop through the subjectIds and issue promises to hydrate them one at a time. Instead we should batch the ids and fetch them all in a single call.

@garethbowen garethbowen self-assigned this Jun 26, 2018
@garethbowen garethbowen added this to To do in 3.0.0 via automation Jun 26, 2018
@garethbowen
Copy link
Member Author

Real world performance improvements on my tecno Y4 with a small db:

Workflow Before After Percent faster
Reload webapp on reports tab 28.0s 20.8s 135%
Report search (no filters) 12.5s 6.1s 205%
Contact search (no filters) 3.5s 3.2s 109%

@garethbowen
Copy link
Member Author

Code review please @dianabarsan

@garethbowen garethbowen moved this from To do to In progress in 3.0.0 Jun 26, 2018
@dianabarsan dianabarsan removed their assignment Jun 26, 2018
@dianabarsan dianabarsan moved this from In progress to Acceptance testing in 3.0.0 Jun 26, 2018
@ngaruko ngaruko self-assigned this Jul 24, 2018
@ngaruko ngaruko closed this as completed Jul 24, 2018
3.0.0 automation moved this from Acceptance testing to Done Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 2 - Medium Normal priority Type: Performance Make something faster
Projects
No open projects
3.0.0
  
Done
Development

No branches or pull requests

3 participants