Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reloading the app while offline shows sync status "required" #5501

Closed
garethbowen opened this issue Mar 14, 2019 · 6 comments
Closed

Reloading the app while offline shows sync status "required" #5501

garethbowen opened this issue Mar 14, 2019 · 6 comments
Assignees
@ngaruko
Labels
Priority: 3 - Low Can be bumped from the release Type: Bug Fix something that isn't working as intended
Projects
3.5.0

Comments

@garethbowen
Copy link
Member

garethbowen commented Mar 14, 2019 •
edited

Steps to reproduce:

  1. Load the app
  2. Fully sync so the hotdog menu says "all reports synced"
  3. Go offline
  4. Refresh the app
  5. Open the hotdog menu

What should happen:

  • No translation warnings in the console
  • The sync status is "unknown"

What actually happens:

  • A console warning is shown
  • The sync status is "reports to sync"

Console log:

Translation for sync.status.undefined doesn't exist

Screenshot from 2019-03-14 16-46-23

Environment:

  • Instance: localhost
  • Browser: Chrome
  • Client platform: Ubuntu
  • App: webapp
  • Version: 3.5.0 (head of master)
@garethbowen garethbowen added Type: Bug Fix something that isn't working as intended Priority: 3 - Low Can be bumped from the release labels Mar 14, 2019
@garethbowen garethbowen self-assigned this Mar 14, 2019
garethbowen added a commit that referenced this issue Mar 14, 2019
@garethbowen
Adds unknown replication status
43aeaf4 
When the user is offline but we know that all docs have been replicated to the server show "unknown" replication state.
Also refactors the replication events.

#5501
@garethbowen garethbowen mentioned this issue Mar 14, 2019
Merged
5 tasks
@garethbowen garethbowen added this to To do in 3.5.0 via automation Mar 14, 2019
@garethbowen
Copy link
Member Author

AT: Testing this depends on #5481 or #4898 being fixed, because currently there's basically always a feedback doc to submit, so instead of seeing "unknown" you'll see "error".

@garethbowen garethbowen moved this from To do to In progress in 3.5.0 Mar 14, 2019
@garethbowen
Copy link
Member Author

Ready for AT in 5501-rationalise-sync-events

@garethbowen garethbowen removed their assignment Mar 21, 2019
@garethbowen garethbowen moved this from In progress to In AT in 3.5.0 Mar 21, 2019
@garethbowen garethbowen self-assigned this Mar 21, 2019
@ngaruko
Copy link
Contributor

ngaruko commented May 8, 2019

Can you look at the conflicts on this branch @garethbowen ?https://github.com/medic/medic/pull/5503/conflicts

garethbowen added a commit that referenced this issue May 8, 2019
@garethbowen
Adds unknown replication status
a463678 
When the user is offline but we know that all docs have been replicated to the server show "unknown" replication state.
Also refactors the replication events.

#5501
@garethbowen
Copy link
Member Author

@ngaruko I've fixed the conflicts - once the build passes you should be good to go again.

@newtewt
Copy link
Contributor

newtewt commented May 10, 2019

I'm seeing this work on the web currently but waiting on the fixes for working in the android-app so we can verify on phone .

@ngaruko ngaruko assigned ngaruko and unassigned garethbowen May 12, 2019
@ngaruko
Copy link
Contributor

ngaruko commented May 12, 2019

LGTM -
image

@ngaruko ngaruko closed this as completed May 12, 2019
3.5.0 automation moved this from In AT to Done May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ngaruko ngaruko

Labels
Priority: 3 - Low Can be bumped from the release Type: Bug Fix something that isn't working as intended
Projects
No open projects
3.5.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@garethbowen @ngaruko @newtewt