Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap text in contact summary and condition cards #5967

Closed
binokaryg opened this issue Sep 20, 2019 · 2 comments
Closed

Wrap text in contact summary and condition cards #5967

binokaryg opened this issue Sep 20, 2019 · 2 comments
Labels
Priority: 2 - Medium Normal priority Type: Bug Fix something that isn't working as intended UI/UX Site design and usability improvements.
Projects
3.8.0

Comments

@binokaryg
Copy link
Member

Describe the bug
If a field in a contact summary or condition card is too long and does not has whitespace, it flows over and does not look good.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a contact profile
  2. Edit the profile and add very long notes without spaces in between
  3. Save the profile
  4. See the problem

Expected behavior
The text should wrap nicely as it does in the forms.

Screenshots
Contact Summary and Condition Card:
image

Form Summary:
image

Environment

  • Instance: cht.app.medicmobile.org
  • Browser: Chrome
  • Client platform: Windows
  • App: webapp
  • Version: 3.6.1
@binokaryg binokaryg added the Type: Bug Fix something that isn't working as intended label Sep 20, 2019
@garethbowen garethbowen added Priority: 2 - Medium Normal priority UI/UX Site design and usability improvements. labels Sep 22, 2019
@garethbowen garethbowen added this to To do in 3.8.0 via automation Sep 22, 2019
@tookam tookam self-assigned this Oct 8, 2019
@tookam tookam moved this from To do to In progress in 3.8.0 Oct 8, 2019
@tookam tookam mentioned this issue Oct 8, 2019
Merged
@tookam
Copy link
Contributor

tookam commented Oct 14, 2019

Ready for AT 5967-wrap-text-in-contact-summary

@tookam tookam moved this from In progress to In AT in 3.8.0 Oct 14, 2019
@ngaruko
Copy link
Contributor

ngaruko commented Oct 16, 2019 •
edited

LGTM
Before (Master)
image

After (branch)
image

ngaruko pushed a commit that referenced this issue Oct 16, 2019
@tookam @ngaruko
Fixes text wrap (#6004)
9573490 
Fixes text wrap

#5967
@ngaruko ngaruko assigned ngaruko and unassigned tookam Oct 16, 2019
@ngaruko ngaruko closed this as completed Oct 16, 2019
3.8.0 automation moved this from In AT to Done Oct 16, 2019
@ngaruko ngaruko removed their assignment Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: 2 - Medium Normal priority Type: Bug Fix something that isn't working as intended UI/UX Site design and usability improvements.
Projects
No open projects
3.8.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tookam @garethbowen @ngaruko @binokaryg