Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current password validation error on Update password form #6020

Closed
ngaruko opened this issue Oct 14, 2019 · 2 comments
Closed

Current password validation error on Update password form #6020

ngaruko opened this issue Oct 14, 2019 · 2 comments
Assignees
@tookam
Labels
Priority: 3 - Low Can be bumped from the release Regression Affects a feature that worked in a previous release Type: Bug Fix something that isn't working as intended
Projects
3.8.0

Comments

@ngaruko
Copy link
Contributor

ngaruko commented Oct 14, 2019

Describe the bug
The current password validation assumes an empty string as an input, which brings incorrect password instead of password required error.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'user Settings ... '
  2. Click on 'update password'
  3. Skip the current password input
  4. Fill in the rest correctly and click the Submit button

The error message is Password is not correct.

Expected behavior
A Password is a required field error should show.

Screenshots
If applicable, add screenshots to help explain your problem.
image ||
image

Environment

  • Instance: local, gamma.dev.medicmobile.org
  • Browser: Firefox, Chrome
  • Client platform: MacOS
  • App: webapp
  • Version: 3.7.*

Additional context
I suspect this has to do with #5635
@ngaruko ngaruko added Type: Bug Fix something that isn't working as intended Regression Affects a feature that worked in a previous release Priority: 3 - Low Can be bumped from the release labels Oct 14, 2019
@ngaruko ngaruko added this to To do in 3.8.0 via automation Oct 14, 2019
@tookam tookam self-assigned this Oct 16, 2019
@tookam tookam moved this from To do to In progress in 3.8.0 Oct 16, 2019
@tookam tookam mentioned this issue Oct 16, 2019
Merged
@dianabarsan
Copy link
Member

Ready for AT on 6020-current-password-validation-error

@dianabarsan dianabarsan moved this from In progress to In AT in 3.8.0 Oct 22, 2019
newtewt pushed a commit that referenced this issue Oct 22, 2019
@tookam @newtewt
Corrects error message being displayed (#6030)
319e133 
Corrects error message being displayed

#6020
@newtewt
Copy link
Contributor

newtewt commented Oct 22, 2019

Seeing the appropriate error as expected above.

@newtewt newtewt closed this as completed Oct 22, 2019
3.8.0 automation moved this from In AT to Done Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tookam tookam

Labels
Priority: 3 - Low Can be bumped from the release Regression Affects a feature that worked in a previous release Type: Bug Fix something that isn't working as intended
Projects
No open projects
3.8.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tookam @ngaruko @newtewt @dianabarsan