Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The number of Feedback docs is incorrect #6239

Closed
garethbowen opened this issue Feb 10, 2020 · 3 comments
Closed

The number of Feedback docs is incorrect #6239

garethbowen opened this issue Feb 10, 2020 · 3 comments
Assignees
@garethbowen
Labels
Priority: 3 - Low Can be bumped from the release Type: Bug Fix something that isn't working as intended
Projects
3.9.0

Comments

@garethbowen
Copy link
Member

garethbowen commented Feb 10, 2020 •
edited

Describe the bug
We show a count of the total number of feedback docs but it includes docs of other types.

To Reproduce
Steps to reproduce the behavior:

  1. Make sure your medic-users-meta database has some feedback docs and some telemetry docs - any system that has been running over the end of the month will have a telemetry doc and feedback docs can be created through the UI, then forcing replication then waiting for them to appear in the meta db.
  2. Go to: Admin > Import & Export data > User Feedback
  3. View the number of feedback docs shown where it says Showing 20 of <total>
  4. Compare this to the actual number of docs in the medic-users-meta db. The shown number will match the total number of docs, including telemetry docs.

Expected behavior
The shown number should only include the feedback docs.

Logs
None

Screenshots
Screenshot from 2020-02-10 14-35-28

Environment

  • Instance: localhost
  • Browser: Firefox
  • Client platform: Linux
  • App: admin
  • Version: 3.8.0
@garethbowen garethbowen added Type: Bug Fix something that isn't working as intended Priority: 3 - Low Can be bumped from the release labels Feb 10, 2020
@garethbowen garethbowen self-assigned this Feb 10, 2020
@garethbowen garethbowen added this to To do in 3.9.0 via automation Feb 10, 2020
@garethbowen garethbowen moved this from To do to In progress in 3.9.0 Feb 10, 2020
@garethbowen garethbowen mentioned this issue Feb 10, 2020
Merged
@garethbowen
Copy link
Member Author

AT this at the same time as #6133

@garethbowen garethbowen moved this from In progress to In AT in 3.9.0 Feb 11, 2020
@garethbowen garethbowen mentioned this issue Feb 11, 2020
Closed
@ngaruko ngaruko self-assigned this Mar 27, 2020
@ngaruko
Copy link
Contributor

ngaruko commented Apr 6, 2020

LGTM
On master:
image

On branch:
image

Back to you @garethbowen for a merge.

@ngaruko ngaruko removed their assignment May 4, 2020
garethbowen added a commit that referenced this issue May 5, 2020
@garethbowen
Adds an API for instance monitoring
67bb273 
Adds an API for monitoring instances with a range of metrics. This can be used manually, or integrated with a monitoring stack such as Prometheus.

Also fixes a bug in the feedback screen of the admin app which reported the wrong number of total feedback docs.

#6133
#6239
#4482
@garethbowen
Copy link
Member Author

Merged.

3.9.0 automation moved this from In AT to Done May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garethbowen garethbowen

Labels
Priority: 3 - Low Can be bumped from the release Type: Bug Fix something that isn't working as intended
Projects
No open projects
3.9.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garethbowen @ngaruko