Show error in targets when user is not associated with the configured place

[ngaruko]

Important: This is a public repository. Anyone in the world can see what's posted here. If you are posting screenshots or log files, please carefully examine them for the presence of any kind of protected health information (PHI). Images or logs containing PHI must be posted in fully-redacted form, with no visible PHI.

Describe the bug
The target page shows blank when the user is not associated with health_center.
To Reproduce
Steps to reproduce the behavior:

1. Start the web app
2. Load brac config
3. Create a user associated with a non health-center place, like a branch
4. Login and go to analytics
5. The page is blank

Expected behavior
There should be a clear message displayed on the page.

Logs
None

Screenshots

Environment

• Instance: local
• Browser: (eg: Firefox, Chrome, incognito mode, etc, which worked, which didn't)
• Client platform: (eg: Windows, MacOS, Linux)
• App: webapp
• Version: 3.13

Additional context
In one of the latest PRs, there has been a context: 'user.parent.type === "health_center"' line added to targets. So, the issue shows after that commit.

[dianabarsan]

I think context: 'user.parent.type === "health_center"' just means that users have no targets. It's not an error, per say.
I agree that we should have a check in the template to display a text like "No targets" instead of a blank page (https://github.com/medic/cht-core/blob/master/webapp/src/ts/modules/analytics/analytics-targets.component.html#L10)

[ngaruko]

@dianabarsan Agree. All we need is to display th message instead of blank page. Though for this case, @jonathanbataire suggested that "Branch users(district_hospital level) don't have any targets configured only target aggregates", so we might need to have the 2 links displayed as it is for admin users (or at least the target aggregates).

[dianabarsan]

The target-aggregates page is controlled by a permission can_aggregate_targets . Does this role have this permission?

[ngaruko]

Ah! You are right. When the aggregate permission is enabled for restricted user, we have the right UI, so we just have to fix/analytics/targets display. /analytics/target-aggregates seems to work ok when the permission if off Target aggregates are disabled

[latin-panda]

This is ready for AT in this PR

[ngaruko]

Looks good.
'no target found message' displayed on the branch
.
Thanks @latin-panda for adding e2e tests for this. Please feel free to merge.

[latin-panda]

Merged to main branch.