Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional tests for Enketo Form functionality #7600

Closed
6 tasks done
jkuester opened this issue Apr 25, 2022 · 5 comments
Closed
6 tasks done

Add additional tests for Enketo Form functionality #7600

jkuester opened this issue Apr 25, 2022 · 5 comments
Assignees
Labels
Enketo Affects Enketo forms Type: Technical issue Improve something that users won't notice
Milestone

Comments

@jkuester
Copy link
Contributor

jkuester commented Apr 25, 2022

Describe the issue
During AT for #6345, there were a number of behavior issues that were found that were not covered by any sort of automated tests. It would be very beneficial to have automated tests for these cases before the next Enketo uplift in #7599.

  • Submit a form with a non-relevant inputs group. Verify the data in the inputs group is still saved.
    • It would also be good to have at least one of the fields in the inputs group to have a constraint that is violated when saving the form. Verify that the form still saves properly since the inputs group is not relevant.
  • Submit a form that uses data loaded from the patient's contact-summary (e.g. the default delivery form loads in the pregnancy UUID). Verify the contact summary data is properly loaded (e.g. that the pregnancy UUID is saved for the delivery report).
  • Submit a form using the instance::db-doc and instance::db-doc-ref functionality and verify the new reports are properly created along with the expected doc-refs. (e.g. new contacts are created for the babies entered into the default delivery form.)
  • Submit a form with a required tel field and verify this is properly handled by the phone-widget proper and the report is saved.
  • Create a completely new test using the enketo widgets we don't have in our forms -> Example forms
@jkuester jkuester added Type: Technical issue Improve something that users won't notice Enketo Affects Enketo forms labels Apr 25, 2022
@ngaruko
Copy link
Contributor

ngaruko commented May 3, 2023

Is this still valid @jkuester ? If yes, should we give send it to to do or backlog?

@jkuester
Copy link
Contributor Author

jkuester commented May 4, 2023

@ngaruko yes it is still valid! (And would be really good to address before #7599.) I am not sure about the difference between to-do and backlog, though.... 😕

@ngaruko
Copy link
Contributor

ngaruko commented May 4, 2023

Thanks @jkuester .
I think @michaelkohn would like the To Do column have 'things that we are definitely going to work on in the immediate future given our current capacity'. So, maybe not in to do yet.

@michaelkohn
Copy link
Member

Looks like this issue is in Allies Code Health, please work with @mrjones-plip to organize.

@tatilepizs tatilepizs self-assigned this Aug 7, 2023
@m5r m5r self-assigned this Aug 31, 2023
tatilepizs added a commit that referenced this issue Sep 19, 2023
Ticket: #7600 

This commit:
* Submit a form with a non-relevant inputs group. Verify the data in the inputs group is still saved.
* Submit a form with fields in the inputs group to have a constraint that is violated when saving the form. Verify that the form still saves properly since the inputs group is not relevant.
* Submit a form that uses data loaded from the patient's contact-summary and verify the contact summary data is properly loaded.
* Submit a form using the instance::db-doc and instance::db-doc-ref functionality and verify the new reports are properly created along with the expected doc-refs.
* Submit a form with a required tel field and verify this is properly handled by the phone-widget proper and the report is saved.
* Create a completely new test using the enketo widgets we don't have in our forms.
@tatilepizs
Copy link
Contributor

Merged into master.
PR #8480

@garethbowen garethbowen added this to the 4.5.0 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enketo Affects Enketo forms Type: Technical issue Improve something that users won't notice
Projects
Status: Done
Development

No branches or pull requests

6 participants