Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentinel stuck in infinite loop when 100 sequential docs fail to execute transitions #8566

Closed
dianabarsan opened this issue Sep 20, 2023 · 1 comment
Closed

Sentinel stuck in infinite loop when 100 sequential docs fail to execute transitions #8566

dianabarsan opened this issue Sep 20, 2023 · 1 comment
Assignees
@dianabarsan
Labels
Priority: 3 - Low Can be bumped from the release Type: Bug Fix something that isn't working as intended
Milestone
4.5.0

Comments

@dianabarsan
Copy link
Member

Describe the bug
This is a corollary to #8539, except the interaction would happen when other doc edits/creates throw errors during running transitions.

To Reproduce
I have not found a reliable way to replicate this without editing code.

Expected behavior
Sentinel queue should advance beyond documents that persistently fail transitions.

Environment

  • Instance: (eg: alpha.dev.medicmobile.org, etc)
  • Browser: (eg: Firefox, Chrome, incognito mode, etc, which worked, which didn't)
  • Client platform: (eg: Windows, MacOS, Linux)
  • App: (eg: webapp, admin, sentinel, api, couch2pg, cht-conf, etc)
  • Version: 3.9+
@dianabarsan dianabarsan added the Type: Bug Fix something that isn't working as intended label Sep 20, 2023
@dianabarsan dianabarsan self-assigned this Sep 20, 2023
@dianabarsan dianabarsan mentioned this issue Sep 21, 2023
Merged
5 tasks
@dianabarsan dianabarsan added the Priority: 3 - Low Can be bumped from the release label Sep 21, 2023
@dianabarsan dianabarsan added this to the 4.5.0 milestone Oct 24, 2023
dianabarsan added a commit that referenced this issue Oct 25, 2023
@dianabarsan
fix(#8566): adds sentinel transition retry cache (#8563)
4bd1ffc 
Adds a cache of 1000 entries (lifo) that tracks how many times Sentinel tried to run transition over a specific change (id + rev). Once the retry count is over 5, the change is skipped and the sentinel queue goes past it.

#8566
@dianabarsan
Copy link
Member Author

Merged to master

Benmuiruri pushed a commit that referenced this issue Oct 26, 2023
@dianabarsan @Benmuiruri
fix(#8566): adds sentinel transition retry cache (#8563)
712c593 
Adds a cache of 1000 entries (lifo) that tracks how many times Sentinel tried to run transition over a specific change (id + rev). Once the retry count is over 5, the change is skipped and the sentinel queue goes past it.

#8566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dianabarsan dianabarsan

Labels
Priority: 3 - Low Can be bumped from the release Type: Bug Fix something that isn't working as intended
Projects
None yet
Milestone
4.5.0
Development

No branches or pull requests
1 participant
@dianabarsan