Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asterisk for required field in form located on new line when in summary group #8585

Closed
jkuester opened this issue Sep 25, 2023 · 1 comment · Fixed by #8768
Closed

Asterisk for required field in form located on new line when in summary group #8585

jkuester opened this issue Sep 25, 2023 · 1 comment · Fixed by #8768
Assignees
@latin-panda
Labels
Affects: 3.17.1 Affects: 3.17.2 Affects: 4.0.0 Affects: 4.0.1 Affects: 4.1.0 Affects: 4.1.1 Affects: 4.1.2 Affects: 4.2.0 Affects: 4.2.1 Affects: 4.2.2 Affects: 4.2.3 Affects: 4.2.4 Affects: 4.3.0 Affects: 4.3.1 Affects: 4.3.2 Affects: 4.4.0 Affects: 4.4.1 Affects: 4.4.2 Affects: 4.5.0 Affects: 4.5.1 Affects: 4.5.2 Enketo Affects Enketo forms Help wanted Good for first time contributions Type: Bug Fix something that isn't working as intended
Milestone
4.6.0

Comments

@jkuester
Copy link
Contributor

jkuester commented Sep 25, 2023 •
edited

Describe the bug
Originally reported on the forum. If you have a required field in your form, you will see an asterisk (*) at the end of the label to indicate the question is required. However, if that field happens to be in a group with the summary appearance, then the asterisk will be shown on a new line below the label (instead of just being appended to the same line as the label).

Expected behavior
image

Actual behavior
image

Additional Information
I have confirmed this behavior from master back to 3.17.1, but I image it goes back much further than that.
@garethbowen garethbowen added the Help wanted Good for first time contributions label Oct 31, 2023
@latin-panda latin-panda self-assigned this Dec 19, 2023
@latin-panda
Copy link
Contributor

latin-panda commented Dec 19, 2023 •
edited

The issue happens with the fields type string. This was introduced in 2016 in this commit

@latin-panda latin-panda added this to the 4.6.0 milestone Dec 19, 2023
@latin-panda latin-panda mentioned this issue Dec 19, 2023
Merged
5 tasks
@latin-panda latin-panda linked a pull request Dec 19, 2023 that will close this issue
fix(#8585): fixing display of question label with summary appearance #8768
Merged
5 tasks
latin-panda added a commit that referenced this issue Dec 21, 2023
@latin-panda
fix(#8585): fixing display of question label with summary appearance (…
59c5fee 
…#8768)
@jkuester jkuester added UI/UX Site design and usability improvements. and removed UI/UX Site design and usability improvements. labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@latin-panda latin-panda

Labels
Affects: 3.17.1 Affects: 3.17.2 Affects: 4.0.0 Affects: 4.0.1 Affects: 4.1.0 Affects: 4.1.1 Affects: 4.1.2 Affects: 4.2.0 Affects: 4.2.1 Affects: 4.2.2 Affects: 4.2.3 Affects: 4.2.4 Affects: 4.3.0 Affects: 4.3.1 Affects: 4.3.2 Affects: 4.4.0 Affects: 4.4.1 Affects: 4.4.2 Affects: 4.5.0 Affects: 4.5.1 Affects: 4.5.2 Enketo Affects Enketo forms Help wanted Good for first time contributions Type: Bug Fix something that isn't working as intended
Projects
Product Team Activities
Status: Done
Milestone
4.6.0
Development

Successfully merging a pull request may close this issue.

fix(#8585): fixing display of question label with summary appearance medic/cht-core
5 participants
@garethbowen @1yuv @jkuester @dianabarsan @latin-panda