Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WDIO #8621

Closed
garethbowen opened this issue Oct 9, 2023 · 0 comments · Fixed by #8658
Closed

Update WDIO #8621

garethbowen opened this issue Oct 9, 2023 · 0 comments · Fixed by #8658
Assignees
Labels
Dependencies Update the project's dependencies/libraries Type: Technical issue Improve something that users won't notice
Milestone

Comments

@garethbowen
Copy link
Member

Describe the issue
We a long way behind on our WDIO dependency and missing out on lots of good changes upstream.

Describe the improvement you'd like
Upgrade.

When I tried the naive approach many suites started failing on cookies and similar, eg:

[chrome 116.0.5845.187 linux #0-6] 1) Log in should set correct cookies
[chrome 116.0.5845.187 linux #0-6] expected { domain: 'localhost', …(7) } to have property 'session'      
      actual expected
      
      { domain: 'localhost', expiry: 1726682707, httpOnly: true, name: 'AuthSession', path: '/', sameSite: 'Lax', secure: false, value: 'YWRtaW46NjUwOUUyRDM6BUJiGEF8nHS-L_zMjUQtihQYoj2evftkgLr5bDPoctQ' }undefined
      
[chrome 116.0.5845.187 linux #0-6] AssertionError: expected { domain: 'localhost', …(7) } to have property 'session'
[chrome 116.0.5845.187 linux #0-6]     at Context.<anonymous> (/home/runner/work/cht-core/cht-core/tests/e2e/default/login/login-logout.wdio-spec.js:87:36)
[chrome 116.0.5845.187 linux #0-6]     at runMicrotasks (<anonymous>)
[chrome 116.0.5845.187 linux #0-6]     at processTicksAndRejections (node:internal/process/task_queues:96:5)

https://github.com/medic/cht-core/actions/runs/6231412091/job/16936676603

@garethbowen garethbowen added Type: Technical issue Improve something that users won't notice Dependencies Update the project's dependencies/libraries labels Oct 9, 2023
@dianabarsan dianabarsan self-assigned this Oct 12, 2023
@dianabarsan dianabarsan linked a pull request Nov 2, 2023 that will close this issue
5 tasks
@dianabarsan dianabarsan added this to the 4.5.0 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Update the project's dependencies/libraries Type: Technical issue Improve something that users won't notice
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants