Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix target UI to match Figma #8686

Closed
8 tasks
latin-panda opened this issue Nov 8, 2023 · 3 comments
Closed
8 tasks

Fix target UI to match Figma #8686

latin-panda opened this issue Nov 8, 2023 · 3 comments
Assignees
Labels
Type: Bug Fix something that isn't working as intended UI/UX Site design and usability improvements.
Milestone

Comments

@latin-panda
Copy link
Contributor

latin-panda commented Nov 8, 2023

Describe:
The design should match Figma (original work), and the documentation should be updated.

Tasks to complete this work:

  • Should keep margins in responsive design (small phones (360 x 670), regular phones, small desktops (10"), and regular desktops (15"))
  • Should align icons when text next to it is long or short
  • Should have a distinctive background color from the page's background
  • Should have radius in corners.
  • Should align the small texts (goals)
  • Verify the target page matches the Figma design when having different device sizes. Attach test evidence in the PR.
  • Update documentation's screens, link CHT Docs PR here.
  • Once merged, backport commit from master to 4.5.x
@latin-panda latin-panda added the UI/UX Site design and usability improvements. label Nov 8, 2023
@latin-panda latin-panda added this to the 4.5.0 milestone Nov 8, 2023
@latin-panda
Copy link
Contributor Author

@n-orlowski @Benmuiruri

  • The margin around the card and other elements is 10px (top and bottom), 12px (left and right). The cards should keep that margin as they extend horizontally (width)
  • The icon should be aligned top in relation to the text.
  • The gray color for the card seems to be #f8f8f8, we need to add a new variable.
  • The border-radius is 8px
  • The small text is aligned to the progress-bar, and has a margin: 7px for the top and 18px for the bottom.

@Benmuiruri
Copy link
Contributor

The following tasks have been completed by #8687

  • Consistent margins in responsive design (small phones (360 x 670), regular phones, small desktops (10"), and regular desktops (15"))
  • Icons aligned when text next to it is long or short
  • Updated Target card background color
  • Updated Target card border radius to 8px
  • Aligned the small texts (goals)
  • Verified the target page matches the Figma design when having different device sizes.
  • Updated documentation's screens, link CHT Docs PR.

Benmuiruri added a commit that referenced this issue Nov 16, 2023
* Chore: add border-radius and gray-bg variables

* Fix: update target border-radius and gray-bg

* Fix: update target card margins on mobile

* Fix: add horizontal border in target card

* Fix: align icon with text

* Fix: match Figma design

* Fix: small adjustment

* Fix: adjust padding

* Fix: adjust progress bar border

* Fix: adjust goal text alignment

* Fix: create variables

* Fix: rename variable

* Fix: update progress bar in target aggregate

* Fix: minor adjustment

* Fix: adjust progress bar

* Fix: adjustments

* Fix: adjustments

* Fix: adjustments

* Fix: adjustments

* Fix: adjustments

* Fix: tiny adjustment

* Fix: tiny adjustment

* Fix: extract class

* Fix: target aggregate adjustment

* Fix: progress bar adjustment
Benmuiruri added a commit that referenced this issue Nov 16, 2023
* Chore: add border-radius and gray-bg variables

* Fix: update target border-radius and gray-bg

* Fix: update target card margins on mobile

* Fix: add horizontal border in target card

* Fix: align icon with text

* Fix: match Figma design

* Fix: small adjustment

* Fix: adjust padding

* Fix: adjust progress bar border

* Fix: adjust goal text alignment

* Fix: create variables

* Fix: rename variable

* Fix: update progress bar in target aggregate

* Fix: minor adjustment

* Fix: adjust progress bar

* Fix: adjustments

* Fix: adjustments

* Fix: adjustments

* Fix: adjustments

* Fix: adjustments

* Fix: tiny adjustment

* Fix: tiny adjustment

* Fix: extract class

* Fix: target aggregate adjustment

* Fix: progress bar adjustment
@Benmuiruri
Copy link
Contributor

Closed with #8687

@1yuv 1yuv added the Type: Bug Fix something that isn't working as intended label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix something that isn't working as intended UI/UX Site design and usability improvements.
Projects
Status: Done
Development

No branches or pull requests

3 participants