Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replicate form deletes to offline users. #5089

Merged
merged 3 commits into from Dec 11, 2018
Merged

Replicate form deletes to offline users. #5089

merged 3 commits into from Dec 11, 2018

Conversation

dianabarsan
Copy link
Member

Description

Fixes bug where deletion of forms would not be replicated to offline users.

#5078

Review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Announced in Changes.md in plain English. Configuration and user documentation on medic-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in Changes.md.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@dianabarsan
Copy link
Member Author

Please review, @garethbowen . Thank you!

garethbowen
garethbowen requested changes Dec 10, 2018
View reviewed changes
Copy link
Member

@garethbowen garethbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this probably deserves a test - maybe just add another doc to tests/e2e/docs-by-replication-key-view.js?

@dianabarsan
Copy link
Member Author

Test added, @garethbowen . I forgot that test existed, sorry.

garethbowen
garethbowen approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@garethbowen garethbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@garethbowen garethbowen merged commit 7c6eebf into master Dec 11, 2018
@garethbowen garethbowen deleted the 5078-replicate-form-deletes branch December 11, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethbowen garethbowen garethbowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dianabarsan @garethbowen