Runs npm dedupe before packaging api and sentinel #5732
Conversation
| @@ -391,7 +391,7 @@ module.exports = function(grunt) { | |||
| .map(module => | |||
| [ | |||
| `cd ${module}`, | |||
| `rm -rf node_modules`, | |||
| `npm dedupe`, | |||
There was a problem hiding this comment.
Running dedupe when there are no node_modules ends up generating an empty package-lock, so the next ci errors so beautifully:
TypeError: Cannot read property '@medic/bulk-docs-utils' of undefined at Object.keys.forEach.name
(/home/diana/.nvm/versions/node/v11.15.0/lib/node_modules/npm/node_modules/lock-verify/index.js:27:40)
npm ci already removes node_modules as its first action.
| (cd shared-libs/${lib} && npm ci && npm test)` | ||
| ) | ||
| .join(' && '); | ||
| const sharedLibs = getSharedLibDirs(); |
There was a problem hiding this comment.
The dedupe actually deletes node_modules from the shared-libs folders, and because some modules require others, testing fails. So we ci all of them first.
| 'build-common', | ||
| 'build-node-modules', |
There was a problem hiding this comment.
Switching the order is a hack.
Running browserify post dedupe ends up not finding stuff.
| @@ -965,7 +963,6 @@ module.exports = function(grunt) { | |||
| 'install-dependencies', | |||
| 'static-analysis', | |||
| 'build', | |||
| 'build-admin', | |||
There was a problem hiding this comment.
We already build-admin in our build -> build-common task. It also fails if we attempt to build it at this stage cause browserify doesn't like it when shared libs don't have installed dependencies.
|
Hey @garethbowen |
There was a problem hiding this comment.
Looks great to me.
If browserify is causing issues another way to solve it is to provide aliases in the Gruntfile so you can tell it to look for the node module somewhere else. But if you're happy with this solution that's fine too!
I'll leave it with you to create an issue and prepare for AT :)
|
@garethbowen |
Description
Post #5694 , our
apiandsentinelbundled doubled in size because of lots of duplicated dependencies (npm packstraight up copies the symlinked folders ).Running
npm dedupereduces our bundle sizes to what they were before.#5739
Code review items
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.