New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message in the error logs when xsltproc is not found #7301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Job! I added a couple of suggestions
7856191
to
85871e7
Compare
The suggestions were applied. @mrjones-plip could you please review? ( @latin-panda is taking time-off for a few days). |
@mrsarm - Sorry, I didn't get to this today. I'll grab it my Monday if @latin-panda hasn't already grabbed it already on her Monday (my Sunday ;) ! |
|
Don't worry @mrjones-plip , I can wait for @latin-panda return , no urgency . Thanks ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, thanks for waiting, I left few minor questions in line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice LGTM!
It'd be nice to have the other it(....)
cases to use the same label style: should do .... when ....
so more uniform, otherwise good to go to AT!
Thanks
Co-authored-by: Jennifer Q <66472237+latin-panda@users.noreply.github.com>
fc7688b
to
925477e
Compare
Needed to re-run CI again because flaky tests so did the grammatical changes as well. Thanks! |
Description
Add clear message in the error logs when the command
xsltproc
used to process forms is not found.#6674
Code review checklist
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.