Removes need for report xml attachments #7596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pause video and audio when nav to next and prev pages in a form coverage unit test * Feedback * fix unit tests
|
Hey @jkuester . Would you mind having a look at this? I'm worried I might be missing some key feature here :) |
jkuester
reviewed
Apr 29, 2022
There was a problem hiding this comment.
Okay, I have spent a bunch of time digging into this and I love it! The implementation is simple and elegant, but should have a huge positive impact on the amount of storage used by the DB! I also really appreaciate the work that went into all the tests. ❤️
I left some comments inline, mostly minor except the one regarding the forms2sms.service.
…attachment # Conflicts: # api/package-lock.json # config/default/forms/app/delivery.xlsx # config/default/forms/app/delivery.xml # config/default/forms/contact/PLACE_TYPE-create.xlsx # config/default/forms/contact/clinic-create.xml # config/default/forms/contact/district_hospital-create.xml # config/default/forms/contact/health_center-create.xml # config/default/forms/contact/person-create.xlsx # config/default/forms/contact/person-create.xml # config/default/forms/contact/person-edit.xlsx # config/default/forms/contact/person-edit.xml # config/standard/forms/app/immunization_visit.xlsx # tests/e2e/forms/submit-default-delivery-form.specs.js # tests/e2e/submit-enketo-form.wdio-spec.js # tests/page-objects/forms/default-delivery-report.po.js # tests/page-objects/forms/photo-upload.wdio.page.js # tests/page-objects/reports/reports.wdio.page.js # webapp/package-lock.json # webapp/package.json # webapp/src/js/enketo/file-manager.js # webapp/src/js/enketo/medic-xpath-extensions.js # webapp/src/js/enketo/widgets/db-object-widget.js # webapp/tests/mocha/unit/enketo/medic-xpath-extensions.spec.js
…attachment # Conflicts: # tests/e2e/protractor/forms/submit-default-delivery-form.specs.js # tests/e2e/protractor/forms/submit-photo-upload-form.spec.js # tests/e2e/protractor/forms/submit-z-score-form.spec.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of relying on xml attachments, uses report fields to populate form model on report edits.
Some changes have been required:
bindJsonToXmlis refactored so it treats arrays (repeats) correctly.Limitations:
Reports created as extra docs might not always be faithful to the model of the form itself.
Also migrates a bunch of e2e tests from protractor to wdio.
#5549
Code review checklist
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.