Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#8535): wait for service worker before waiting for the popup. #8610

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix(#8535): wait for service worker before waiting for the popup. #8610

merged 1 commit into from
Oct 4, 2023

Conversation

dianabarsan
Copy link
Member

@dianabarsan dianabarsan commented Oct 4, 2023 •
edited by github-actions bot

Description

#8535

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@dianabarsan
Copy link
Member Author

@njuguna-n @njogz (donno which one is the right one :D) would you please review this tiny PR? Thanks!!

njuguna-n
njuguna-n approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@njuguna-n njuguna-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dianabarsan dianabarsan merged commit bb115e2 into master Oct 4, 2023
34 checks passed
@dianabarsan dianabarsan deleted the 8535-fix branch October 4, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuguna-n njuguna-n njuguna-n approved these changes

@njogz njogz Awaiting requested review from njogz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dianabarsan @njuguna-n