Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#9108): block updating admin only docs #9109

Merged
merged 8 commits into from
May 16, 2024

Conversation

garethbowen
Copy link
Member

@garethbowen garethbowen commented May 10, 2024

Description

#9108

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@garethbowen garethbowen requested a review from sugat009 May 10, 2024 14:26
@garethbowen
Copy link
Member Author

@sugat009 Can I get a review please? I won't merge this until #9107 is merged but it can be reviewed now and rebased later. Reproduction steps in the linked issue...

Base automatically changed from 8886-block-user-settings-updates to master May 16, 2024 07:35
@garethbowen garethbowen merged commit 2bebd76 into master May 16, 2024
39 checks passed
@garethbowen garethbowen deleted the 9108-block-overwriting-protected-docs branch May 16, 2024 08:48
@garethbowen garethbowen changed the title fix(#9108): block updating admin only apps fix(#9108): block updating admin only docs May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants