Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#9203): add facility_id backward compatibility in admin app #9204

Merged
merged 5 commits into from
Jun 25, 2024

Conversation

Benmuiruri
Copy link
Contributor

@Benmuiruri Benmuiruri commented Jun 24, 2024

Description

Type casts users with existing string facility_id to Array facility_id that can be loaded in the edit form of the Admin app.

Closes #9203

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@latin-panda latin-panda self-requested a review June 25, 2024 06:16
Copy link
Contributor

@latin-panda latin-panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Benmuiruri
Copy link
Contributor Author

I'm going to merge this Jenni. Thanks for your contribution.

@Benmuiruri Benmuiruri merged commit 7bcb375 into master Jun 25, 2024
41 checks passed
@Benmuiruri Benmuiruri deleted the facility-backward-compatibility branch June 25, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure backward compatibility of facility_id in Admin app
2 participants