Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document training app feature for android flavors #678

Merged
merged 8 commits into from Apr 12, 2022

Conversation

abbyad
Copy link
Contributor

@abbyad abbyad commented Apr 12, 2022

@abbyad abbyad requested a review from latin-panda April 12, 2022 14:49
@abbyad abbyad marked this pull request as ready for review April 12, 2022 14:49
Copy link
Contributor

@latin-panda latin-panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abbyad abbyad merged commit e43dad3 into main Apr 12, 2022
@abbyad abbyad deleted the android-258-training-app branch April 12, 2022 15:42
@ngaruko
Copy link

ngaruko commented Apr 20, 2022

Tested with unbranded but switching on and off the IS_TRAINING_APP flag

unbranded {
      // we will not create project-specific src directories
      // for `unbranded` - it will use the defaults in
      // src/main
      dimension = 'brand'
      buildConfigField "boolean", "IS_TRAINING_APP", 'true'
    }

When the flag is set to true, a toast shows at the beginning of the app
Screen Shot 2022-04-20 at 1 00 11 PM

and an orange contour around all screens
Screen Shot 2022-04-20 at 1 01 15 PM
And none when the flag is set to 'false'
image

Good to merge @abbyad .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants