Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have models in reports_tables folder be incremental models #20

Closed
njogz opened this issue Jun 22, 2023 · 3 comments
Closed

Have models in reports_tables folder be incremental models #20

njogz opened this issue Jun 22, 2023 · 3 comments

Comments

@njogz
Copy link
Contributor

njogz commented Jun 22, 2023

Two models defined in the reports_tables folder are failing with the error described here. The types/data_record has the same query but that one passes without any errors. To unblock the PR I made the change to have the models create regular tables but incremental tables are ideal for performance reasons.
@njogz njogz mentioned this issue Jun 22, 2023
Merged
@andrablaj
Copy link
Member

@njuguna-n what is the status of this issue? Is it still relevant?

@njuguna-n
Copy link
Contributor

@andrablaj this is still not addressed and still relevant so let's keep the issue open.

@njuguna-n
Copy link
Contributor

This can now be closed since all base models are now incremental tables and we no longer have the report_tables models as part of the base models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Product Team Activities
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@njogz @andrablaj @njuguna-n