-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hard coded dbconnection #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realice that we need to add to tests/run_dbt_tests.sh
:
export POSTGRES_USER=root
export POSTGRES_PASSWORD=supercoolpassword
export POSTGRES_SCHEMA=v1
@lorerod I have added POSTGRES_USER test script, the other variables were already present. |
It is named differently, though. We need to add
And, also there is a dependency that is out of date:
|
Thanks. I have added the variables and updated the package. |
This PR is still failing because it can't find |
@njuguna-n Can this be merged to BRAC-models now? |
No description provided.