Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hard coded dbconnection #41

Merged
merged 13 commits into from
Jan 24, 2024
Merged

Fix hard coded dbconnection #41

merged 13 commits into from
Jan 24, 2024

Conversation

njuguna-n
Copy link
Contributor

No description provided.

Copy link
Contributor

@lorerod lorerod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@lorerod lorerod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realice that we need to add to tests/run_dbt_tests.sh:

export POSTGRES_USER=root
export POSTGRES_PASSWORD=supercoolpassword
export POSTGRES_SCHEMA=v1

@njuguna-n
Copy link
Contributor Author

@lorerod I have added POSTGRES_USER test script, the other variables were already present.

@lorerod
Copy link
Contributor

lorerod commented Nov 10, 2023

It is named differently, though. We need to add

export POSTGRES_PASSWORD=supercoolpassword
export POSTGRES_SCHEMA=v1

And, also there is a dependency that is out of date:

Installing calogica/dbt_date
Installed from version 0.9.1
 Updated version available: 0.10.0
[15](https://github.com/medic/cht-pipeline/actions/runs/6825693693/job/18567603460?pr=41#step:10:16):42:54  
Updates available for packages: ['calogica/dbt_date']                 
Update your versions in packages.yml, then run dbt deps

@njuguna-n
Copy link
Contributor Author

Thanks. I have added the variables and updated the package.

@njuguna-n
Copy link
Contributor Author

This PR is still failing because it can't find v1.couchdb. I will fix that in this ticket.

@lorerod
Copy link
Contributor

lorerod commented Nov 17, 2023

@njuguna-n Can this be merged to BRAC-models now?

@njuguna-n njuguna-n merged commit d7e70b7 into BRAC-models Jan 24, 2024
2 checks passed
@njuguna-n njuguna-n deleted the BRAC-models-fixes branch January 24, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants