-
Notifications
You must be signed in to change notification settings - Fork 1
/
validation.spec.ts
217 lines (175 loc) · 10.6 KB
/
validation.spec.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
import { DateTime } from 'luxon';
import { expect } from 'chai';
import { Validation } from '../../src/lib/validation';
import { mockSimpleContactType, mockPlace } from '../mocks';
import RemotePlaceResolver from '../../src/lib/remote-place-resolver';
type Scenario = {
type: string;
prop?: string;
isValid: boolean;
propertyParameter?: string | string[] | object;
altered?: string;
propertyErrorDescription?: string;
error?: string;
};
const EMAIL_REGEX = '^[a-zA-Z0-9._+-]+@[a-zA-Z0-9.-]+.[a-zA-Z]{2,}$';
const GENDER_OPTIONS = { male: 'Male', female: 'Female' };
const CANDIES_OPTIONS = { chocolate: 'Chocolate', strawberry: 'Strawberry' };
const scenarios: Scenario[] = [
{ type: 'string', prop: undefined, isValid: false, error: 'Required' },
{ type: 'string', prop: 'abc', isValid: true },
{ type: 'string', prop: ' ab\nc', isValid: true, altered: 'abc' },
{ type: 'string', prop: 'Mr. Sand(m-a-n)', isValid: true, altered: 'Mr. Sand(m-a-n)' },
{ type: 'string', prop: 'Université ', isValid: true, altered: 'Université' },
{ type: 'string', prop: `Infirmière d'Etat`, isValid: true, altered: `Infirmière d'Etat` },
{ type: 'string', prop: '', isValid: false, altered: '', error: 'Required' },
{ type: 'phone', prop: undefined, isValid: false, error: 'Required' },
{ type: 'phone', prop: '+254712345678', isValid: true, altered: '0712 345678', propertyParameter: 'KE' },
{ type: 'phone', prop: '712345678', isValid: true, altered: '0712 345678', propertyParameter: 'KE' },
{ type: 'phone', prop: '+254712345678', isValid: false, altered: '0712 345678', propertyParameter: 'UG', error: 'Not a valid' },
{ type: 'phone', prop: '+17058772274', isValid: false, altered: '(705) 877-2274', propertyParameter: 'KE', error: 'KE' },
{ type: 'regex', prop: undefined, isValid: false, error: 'Required' },
{ type: 'regex', propertyParameter: '^\\d{6}$', prop: '123456', isValid: true },
{ type: 'regex', propertyParameter: '^\\d{6}$', prop: ' 123456 *&%', isValid: true, altered: '123456' },
{ type: 'regex', propertyParameter: '^\\d{6}$', prop: '1234567', isValid: false, error: 'six digit', propertyErrorDescription: 'six digit number' },
{ type: 'regex', propertyParameter: EMAIL_REGEX, prop: 'email@address.com', isValid: true, altered: 'email@address.com' },
{ type: 'regex', propertyParameter: EMAIL_REGEX, prop: '.com', isValid: false, propertyErrorDescription: 'valid email address', error: 'email' },
{ type: 'regex', propertyParameter: undefined, prop: 'abc', isValid: false, error: 'missing parameter' },
{ type: 'name', prop: undefined, isValid: false, error: 'Required' },
{ type: 'name', prop: 'abc', isValid: true, altered: 'Abc' },
{ type: 'name', prop: 'a b c', isValid: true, altered: 'A B C' },
{ type: 'name', prop: 'Mr. Sand(m-a-n)', isValid: true, altered: 'Mr Sand(m-a-n)' },
{ type: 'name', prop: 'WELDON KO(E)CH \n', isValid: true, altered: 'Weldon Ko(e)ch' },
{ type: 'name', prop: 'S \'am \'s', isValid: true, altered: 'S\'am\'s' },
{ type: 'name', prop: 'KYAMBOO/KALILUNI', isValid: true, altered: 'Kyamboo / Kaliluni' },
{ type: 'name', prop: 'NZATANI / ILALAMBYU', isValid: true, altered: 'Nzatani / Ilalambyu' },
{ type: 'name', prop: 'Sam\'s CHU', propertyParameter: ['CHU', 'Comm Unit'], isValid: true, altered: 'Sam\'s' },
{ type: 'name', prop: 'Jonathan M.Barasa', isValid: true, altered: 'Jonathan M Barasa' },
{ type: 'name', prop: 'Robert xiv', isValid: true, altered: 'Robert XIV' },
{ type: 'name', prop: ' ', isValid: true, altered: '' },
{ type: 'dob', prop: undefined, isValid: false, error: 'Required' },
{ type: 'dob', prop: '', isValid: false },
{ type: 'dob', prop: '2016/05/25', isValid: false },
{ type: 'dob', prop: 'May 25, 2016', isValid: false },
{ type: 'dob', prop: '2030-05-25', isValid: false },
{ type: 'dob', prop: '2016-05-25', isValid: true, altered: '2016-05-25' },
{ type: 'dob', prop: ' 20 16- 05- 25 ', isValid: true, altered: '2016-05-25' },
{ type: 'dob', prop: '20', isValid: true, altered: DateTime.now().minus({ years: 20 }).toISODate() },
{ type: 'dob', prop: ' 20 ', isValid: true, altered: DateTime.now().minus({ years: 20 }).toISODate() },
{ type: 'dob', prop: 'abc', isValid: false, altered: 'abc' },
{ type: 'dob', prop: ' 1 0 0 ', isValid: true, altered: DateTime.now().minus({ years: 100 }).toISODate() },
{ type: 'dob', prop: '-1', isValid: false, altered: '-1' },
{ type: 'dob', prop: '15/2/1985', isValid: true, altered: '1985-02-15' },
{ type: 'dob', prop: '1/2/1 985', isValid: true, altered: '1985-02-01' },
{ type: 'dob', prop: '1/13/1985', isValid: false },
{ type: 'select_one', prop: undefined, isValid: false, error: 'Required' },
{ type: 'select_one', prop: ' male', isValid: true, propertyParameter: GENDER_OPTIONS },
{ type: 'select_one', prop: 'female ', isValid: true, propertyParameter: GENDER_OPTIONS },
{ type: 'select_one', prop: 'FeMale ', isValid: false, propertyParameter: GENDER_OPTIONS },
{ type: 'select_one', prop: 'f', isValid: false, propertyParameter: GENDER_OPTIONS },
{ type: 'select_one', prop: '', isValid: false, propertyParameter: GENDER_OPTIONS },
{ type: 'select_multiple', prop: undefined, isValid: false, error: 'Required' },
{ type: 'select_multiple', prop: 'chocolate', isValid: true, propertyParameter: CANDIES_OPTIONS },
{ type: 'select_multiple', prop: 'chocolate strawberry', isValid: true, propertyParameter: CANDIES_OPTIONS },
{ type: 'select_multiple', prop: ' chocolate strawberry', isValid: true, propertyParameter: CANDIES_OPTIONS },
{ type: 'select_multiple', prop: 'c,s', isValid: false, propertyParameter: CANDIES_OPTIONS, error: 'Invalid values' },
{ type: 'select_multiple', prop: '', isValid: false, propertyParameter: CANDIES_OPTIONS, error: 'required' },
{ type: 'generated', prop: 'b', propertyParameter: 'a {{ place.prop }} c', isValid: true, altered: 'a b c' },
{ type: 'generated', prop: 'b', propertyParameter: '{{ contact.name }} ({{ lineage.PARENT }})', isValid: true, altered: 'contact (Parent)' },
{ type: 'generated', prop: 'b', propertyParameter: 'x {{ contact.dne }}', isValid: true, altered: 'x ' },
];
describe('lib/validation.ts', () => {
for (const scenario of scenarios) {
it(`scenario: ${JSON.stringify(scenario)}`, () => {
const contactType = mockSimpleContactType(scenario.type, scenario.propertyParameter, scenario.propertyErrorDescription);
const place = mockPlace(contactType, scenario.prop);
const actualValidity = Validation.getValidationErrors(place);
expect(actualValidity.map(a => a.property_name)).to.deep.eq(scenario.isValid ? [] : ['place_prop']);
if (scenario.error) {
expect(actualValidity?.[0].description).to.include(scenario.error);
}
Validation.format(place);
expect(place.properties.prop).to.eq(scenario.altered ?? scenario.prop);
});
}
it('unknown property type throws', () => {
const contactType = mockSimpleContactType('unknown`', undefined);
const place = mockPlace(contactType, 'prop');
expect(() => Validation.getValidationErrors(place)).to.throw('unvalidatable');
});
it('property with required:false can be empty', () => {
const contactType = mockSimpleContactType('string', undefined);
contactType.place_properties[contactType.place_properties.length-1].required = false;
const place = mockPlace(contactType, undefined);
place.properties = { name: 'foo' };
place.hierarchyProperties = { PARENT: 'parent' };
expect(Validation.getValidationErrors(place)).to.be.empty;
});
it('#91 - parent is invalid when required:false but resolution is NoResult', () => {
const contactType = mockSimpleContactType('string', undefined);
contactType.hierarchy[0].required = false;
const place = mockPlace(contactType, 'prop');
place.resolvedHierarchy[1] = RemotePlaceResolver.NoResult;
console.log('Validation.getValidationErrors(place)', Validation.getValidationErrors(place));
expect(Validation.getValidationErrors(place)).to.deep.eq([{
property_name: 'hierarchy_PARENT',
description: `Cannot find 'parent' matching 'parent'`,
}]);
});
it('parent is invalid when missing but expected', () => {
const contactType = mockSimpleContactType('string', undefined);
const place = mockPlace(contactType, 'prop');
delete place.resolvedHierarchy[1];
expect(Validation.getValidationErrors(place)).to.deep.eq([{
property_name: 'hierarchy_PARENT',
description: `Cannot find 'parent' matching 'parent'`,
}]);
});
it('parent is valid when missing and not expected', () => {
const contactType = mockSimpleContactType('string', undefined);
contactType.hierarchy[0].required = false;
const place = mockPlace(contactType, 'prop');
delete place.resolvedHierarchy[1];
expect(Validation.getValidationErrors(place)).to.be.empty;
});
it('replacement property is validated and altered as property_name:name', () => {
const contactType = mockSimpleContactType('string', undefined);
const place = mockPlace(contactType, 'foo');
place.hierarchyProperties.replacement = 'sin bad';
Validation.format(place);
expect(place.hierarchyProperties.replacement).to.eq('Sin Bad');
const validationErrors = Validation.getValidationErrors(place);
expect(validationErrors).to.deep.eq([{
property_name: 'hierarchy_replacement',
description: `Cannot find 'contacttype-name' matching 'Sin Bad' under 'Parent'`,
}]);
});
it('user_role property empty throws', () => {
const contactType = mockSimpleContactType('string', undefined);
contactType.user_role = [];
const place = mockPlace(contactType, 'prop');
expect(() => Validation.getValidationErrors(place)).to.throw('unvalidatable');
});
it('user_role property contains empty string throws', () => {
const contactType = mockSimpleContactType('string', undefined);
contactType.user_role = [''];
const place = mockPlace(contactType, 'prop');
expect(() => Validation.getValidationErrors(place)).to.throw('unvalidatable');
});
it('user role is invalid when not allowed', () => {
const contactType = mockSimpleContactType('string', undefined);
contactType.user_role = ['supervisor', 'stock_manager'];
const place = mockPlace(contactType, 'prop');
const formData = {
place_prop: 'abc',
contact_prop: 'efg',
garbage: 'ghj',
user_role: 'supervisor stockmanager',
};
place.setPropertiesFromFormData(formData);
expect(Validation.getValidationErrors(place)).to.deep.eq([{
property_name: 'user_role',
description: `Invalid values for property "Roles": stockmanager`
}]);
});
});