Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the multiple DoB formats used by sample UG inputs #119

Closed
kennsippell opened this issue Mar 25, 2024 · 3 comments · Fixed by #120
Closed

Support the multiple DoB formats used by sample UG inputs #119

kennsippell opened this issue Mar 25, 2024 · 3 comments · Fixed by #120
Assignees
Labels
Type: Improvement Make something better.

Comments

@kennsippell
Copy link
Member

  • There are hundreds of values in the format 13/2/1985 and hundreds in the format 1977-08-14. Currently we only support the latter. Should we support both?

Originally posted by @kennsippell in #38

@jonathanbataire
Copy link

jonathanbataire commented Mar 25, 2024

Kenn this would cause a nightmare dealing with data in psql lets stick to yyyy-mm-dd
there were mistakes during unvalidated user creation hence these various formats

@jonathanbataire
Copy link

ignore if in the json it shows up as yyyy-mm-dd and this is just for the ui and template :)

@kennsippell
Copy link
Member Author

kennsippell commented Mar 25, 2024

@jonathanbataire This is the accepted input for DoB, but the output will always be in ISO format yyyy-mm-dd.
Can see here in the unit test, the inputs are different but the outputs are the same.

@kennsippell kennsippell added the Type: Improvement Make something better. label Mar 29, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Make something better.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants