Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declarative Config - Rename passGroupWithCount to passesIfGroupCount #283

Closed
kennsippell opened this issue Dec 17, 2019 · 2 comments
Closed

Declarative Config - Rename passGroupWithCount to passesIfGroupCount #283

kennsippell opened this issue Dec 17, 2019 · 2 comments
Assignees
@senseibara
Labels
Priority: 2 - Medium Normal priority. Type: Improvement Make something better

Comments

@kennsippell
Copy link
Member

Based on UAT and feedback during documentation review (medic/medic-docs#164), we should rename passGroupWithCount to passesIfGroupCount.

It is nice to do this before medic-conf 3.1 releases so the initial release of this feature has the correct nomenclature.
@kennsippell kennsippell added the Priority: 2 - Medium Normal priority. label Dec 17, 2019
@kennsippell kennsippell self-assigned this Dec 17, 2019
This was referenced Dec 17, 2019
Merged
Merged
@kennsippell
Copy link
Member Author

@senseibara I've deployed these changes to https://sih-muso-mali.dev.medicmobile.org. Would you mind giving this another quick acceptance test?

@kennsippell kennsippell mentioned this issue Dec 18, 2019
Merged
@senseibara
Copy link

looks good to me

@ngaruko ngaruko closed this as completed Dec 18, 2019
kennsippell added a commit that referenced this issue Dec 19, 2019
@kennsippell
Declarative Config - Rename passGroupWithCount to passesIfGroupCount (#…
7cad6d3 
…283)

Based on UAT and feedback during documentation review (medic/medic-docs#164) this PR renames passGroupWithCount to passesIfGroupCount.
@SCdF SCdF added the Type: Improvement Make something better label Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@senseibara senseibara

Labels
Priority: 2 - Medium Normal priority. Type: Improvement Make something better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@SCdF @ngaruko @kennsippell @senseibara