Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing optional appliesIf attribute on contact summary cards causes crash #322

Closed
kennsippell opened this issue Apr 30, 2020 · 7 comments
Closed

Missing optional appliesIf attribute on contact summary cards causes crash #322

kennsippell opened this issue Apr 30, 2020 · 7 comments
Assignees
@garethbowen @newtewt
Labels
Type: Bug Fix something that isn't working as intended

Comments

@kennsippell
Copy link
Member

Documentation shows cards.appliesIf as being optional. If it is missing, the contact summary fails to render.

Configuration error in contact-summary function: card.appliesIf is not a function
@MaxDiz MaxDiz added the Type: Documentation Improvements or additions to the documentation. label May 1, 2020
@MaxDiz
Copy link

MaxDiz commented May 1, 2020

@kennsippell can I move this over to medic-docs?

@kennsippell
Copy link
Member Author

kennsippell commented May 2, 2020 •
edited
Loading

@MaxDiz The appliesIf attribute is documented as being optional but the current behavior is that it is required. I opened thinking it would be a bug fix since the documented behavior seems appropriate to me. It may be possible that we decide to make it required - in which case we can update the documentation. Let's keep it a bug for now?

@kennsippell kennsippell added Type: Bug Fix something that isn't working as intended and removed Type: Documentation Improvements or additions to the documentation. labels May 2, 2020
@garethbowen
Copy link
Member

@kennsippell I guess it should default to true?

@kennsippell
Copy link
Member Author

kennsippell commented May 4, 2020 •
edited
Loading

@garethbowen Yep. I believe true is currently the default for tasks, targets, and fields.

@garethbowen garethbowen self-assigned this May 13, 2020
@garethbowen garethbowen mentioned this issue May 13, 2020
Merged
@dianabarsan
Copy link
Member

Ready for AT on 322-appliesIf-defaults-to-true

@newtewt newtewt closed this as completed Jun 18, 2020
@newtewt newtewt reopened this Jun 18, 2020
@newtewt newtewt self-assigned this Jun 25, 2020
@newtewt
Copy link
Contributor

newtewt commented Jun 26, 2020

@garethbowen feel free to close this. I'm seeing this work without appliesIf defined, as a function, and as a bool.

@garethbowen
Copy link
Member

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garethbowen garethbowen

@newtewt newtewt

Labels
Type: Bug Fix something that isn't working as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@garethbowen @kennsippell @newtewt @dianabarsan @MaxDiz