Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow phone numbers in Name fields #1660

Closed
alxndrsn opened this issue Nov 24, 2015 · 6 comments
Closed

Disallow phone numbers in Name fields #1660

alxndrsn opened this issue Nov 24, 2015 · 6 comments
Labels
Status: Blocked waiting for design Blocked waiting for design input

Comments

@alxndrsn
Copy link
Contributor

There is concern, especially when registering a Family, that a user may enter a phone number in the name field. If we could validate the name field to disallow numbers, or disallow phone numbers, then this might prevent bad data being submitted.

@abbyad
Copy link
Contributor

abbyad commented Dec 8, 2015

We can easily set a regex... but a bigger question is what to restrict this to. Do we want to accept only letters and some special characters, or do we want to exclude series of numbers?

@alxndrsn if you have a suggestion of a regex I can include that in our testing version of the forms.

@abbyad abbyad assigned alxndrsn and unassigned abbyad Dec 8, 2015
@abbyad abbyad added the Status: Blocked waiting for design Blocked waiting for design input label Dec 8, 2015
@alxndrsn
Copy link
Contributor Author

/^\D*$/ should exclude any digits; ^[0-9+]*$/ should exclude digits and the + character. If we want to exclude punctuation as well, then things would get more complicated, but this seems less important if we're just trying to protect against name and phone number fields being confused.

@alxndrsn alxndrsn assigned abbyad and unassigned alxndrsn Dec 14, 2015
@abbyad abbyad added this to the Iteration 2015-51 milestone Dec 15, 2015
@ghost ghost added the 1 - Scheduled label Feb 9, 2016
@ghost
Copy link

ghost commented Feb 9, 2016

Is this a priority for February 21st? If not, I'd propose that this should be deprioritized for this iteration to allow additional time for form performance improvement, targets, and analytics support.

@abbyad
Copy link
Contributor

abbyad commented Feb 17, 2016

@sglangevin is this still required?

@abbyad abbyad assigned sglangevin and unassigned abbyad Feb 17, 2016
@sglangevin
Copy link

@abbyad I think we can hold off on this for now. During our last discussion, we raised the point that CHPs might need numbers to indicate different families with the same name, so we didn't want to limit this field to exclude numbers. I could see limiting the number of numbers that are in this field, but perhaps we should just monitor the data first to see how often this mistake happens? I will confirm this today.

@garethbowen
Copy link
Member

This can be done as part of xforms validation. Reopen if there's anything we need to do in the app to allow this.

@sglangevin sglangevin removed their assignment Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Blocked waiting for design Blocked waiting for design input
Projects
None yet
Development

No branches or pull requests

4 participants