Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expected bug in tour on mobile #2419

Closed
alxndrsn opened this issue Jun 21, 2016 · 3 comments
Closed

Expected bug in tour on mobile #2419

alxndrsn opened this issue Jun 21, 2016 · 3 comments
Labels
Type: Bug Fix something that isn't working as intended
Milestone
June 27th - July ...

Comments

@alxndrsn
Copy link
Contributor

Angular's .scope() function is not available on production systems, but is used in the tour at https://github.com/medic/medic-webapp/blob/develop/static/js/modules/tour.js#L39.

To debug this problem, you can run the app locally, but access it via http://192.168.0.1:5988 as it detects if it's in production mode by checking if the domain is localhost – https://github.com/medic/medic-webapp/blob/33f84e8fb80d27db72df41af66a27571728b36bc/static/js/app.js#L65

Ref #2407
@alxndrsn alxndrsn added the Type: Bug Fix something that isn't working as intended label Jun 21, 2016
@garethbowen garethbowen added this to the June 27th - July 11th milestone Jul 5, 2016
garethbowen added a commit that referenced this issue Jul 5, 2016
@garethbowen
Removed scope from tour code. Issue: #2419
ab67e2e
@garethbowen
Copy link
Member

Patched that bug. The tour is still really out of date but #2212 should fix that.

@alxndrsn
Copy link
Contributor Author

alxndrsn commented Jul 5, 2016

1 comment inline.

@alxndrsn alxndrsn assigned garethbowen and unassigned alxndrsn Jul 5, 2016
@garethbowen garethbowen removed their assignment Jul 5, 2016
@ngaruko
Copy link
Contributor

ngaruko commented Feb 9, 2017

Moving it to ready. Tour to be updated as in #2212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Fix something that isn't working as intended
Projects
None yet
Milestone
June 27th - July 11th
Development

No branches or pull requests
3 participants
@alxndrsn @garethbowen @ngaruko