Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporting reports filtered by place results in an empty xml #3593

Closed
eljhkrr opened this issue Jun 29, 2017 · 8 comments
Closed

Exporting reports filtered by place results in an empty xml #3593

eljhkrr opened this issue Jun 29, 2017 · 8 comments
Labels
Priority: 1 - High Blocks the next release. Type: Bug Fix something that isn't working as intended
Milestone
June 26 - July 10

Comments

@eljhkrr
Copy link
Member

eljhkrr commented Jun 29, 2017

No description provided.

@SCdF
Copy link
Contributor

SCdF commented Jun 29, 2017

Hi @eljhkrr this sounds like a bug.

Can you please provide more information?

For example:

  • The server / partner it is relevant to
  • Steps to reproduce (and whether or not it was reproducible)
  • What you would expect to happen
  • What actually happened

Any other relevant information, such as the software version, browser version etc.

@SCdF SCdF added the Status: Blocked Unable to progress this. label Jun 29, 2017
@eljhkrr
Copy link
Member Author

eljhkrr commented Jun 29, 2017

@SCdF This was observed on the kilifikids-kaiti instance.

To reproduce the bug:
Filter reports by place, confirm there are reports for the particular place and then export them. Only header fields will be present on the exported xml without any data rows. Exports with type, date & status filters are working as expected.

@SCdF
Copy link
Contributor

SCdF commented Jun 29, 2017

Thanks for filling in more details @eljhkrr. I looked up the software version for you: it's 2.11.3.

(You can find out which version of the software you're running on the about page)

I'd be also interested in the browser you're using, it's version, and the operating system you're running on.

@sglangevin
Copy link

@SCdF there are two parts to this:

First, exporting has moved and changed a lot from 0.4 to 2.x. It's now on the Reports tab and we don't have different options for which format the file is downloaded in. We've had requests from some partners that we bring back the csv and xls options for downloads. This is something I'd like to include in 2.14 so it's not prioritized for now but will be soon.

The second piece of this is a bug that I haven't had a chance to file yet but that I discovered during recent testing of the export feature. All of the filters are working as expected except for the filter by place. I'm going to update the title of this issue to represent the bug we have in filtering by place and we can open a new issue (to be fixed in the future) for the file type of the export.

@sglangevin sglangevin changed the title Exporting filtered reports does not export any data Exporting reports filtered by place results in an empty xml Jun 29, 2017
@sglangevin
Copy link

I've updated the title here - @eljhkrr's steps to reproduce should work well as that's how I've recreated the bug on my laptop.

@sglangevin sglangevin added Type: Bug Fix something that isn't working as intended and removed Status: Blocked Unable to progress this. labels Jun 29, 2017
@sglangevin sglangevin added this to the June 26 - July 10 milestone Jul 3, 2017
@sglangevin sglangevin added the Priority: 1 - High Blocks the next release. label Jul 3, 2017
@garethbowen garethbowen assigned garethbowen and unassigned eljhkrr Jul 5, 2017
garethbowen added a commit to medic/medic-api that referenced this issue Jul 6, 2017
@garethbowen
Hydrates the contacts when exporting
255a2f6 
Exporting reports and messages was broken by the recent linked
contacts change because the exports can return details on the
parents, for example, "parent.name". This hydrates all the db rows
before they get mapped into the output format.

medic/cht-core#3593
garethbowen added a commit that referenced this issue Jul 6, 2017
@garethbowen
Adds the clinic back into lucene index
982ff64 
Exporting reports filtered by place relies on the "clinic" field
so we need to include it in the lucene index.

Also fixes an exception that's thrown when doc.fields is null.

#3593
This was referenced Jul 6, 2017
Merged
Merged
@garethbowen
Copy link
Member

Two PRs for code review please @estellecomment

estellecomment pushed a commit that referenced this issue Jul 6, 2017
@garethbowen @estellecomment
Adds the clinic back into lucene index (#3593)
804fa53 
Exporting reports filtered by place relies on the "clinic" field
so we need to include it in the lucene index.

Also fixes an exception that's thrown when doc.fields is null.

#3593
@estellecomment
Copy link
Contributor

Commented on the commit for api one : medic/medic-api@255a2f6

And then good to merge.

garethbowen added a commit to medic/medic-api that referenced this issue Jul 6, 2017
@garethbowen
Hydrates the contacts when exporting
b3d37c7 
Exporting reports and messages was broken by the recent linked
contacts change because the exports can return details on the
parents, for example, "parent.name". This hydrates all the db rows
before they get mapped into the output format.

medic/cht-core#3593
@garethbowen garethbowen removed their assignment Jul 6, 2017
@sglangevin
Copy link

Working well in v2.13.0-beta.2. Moving to ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: 1 - High Blocks the next release. Type: Bug Fix something that isn't working as intended
Projects
None yet
Milestone
June 26 - July 10
Development

No branches or pull requests
5 participants
@SCdF @estellecomment @sglangevin @garethbowen @eljhkrr