Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Targets tab has no Loading spinner on initial load #4241

Closed
alxndrsn opened this issue Feb 26, 2018 · 2 comments
Closed

Targets tab has no Loading spinner on initial load #4241

alxndrsn opened this issue Feb 26, 2018 · 2 comments
Assignees
@ngaruko
Labels
Priority: 3 - Low Can be bumped from the release Type: Improvement Make something better UI/UX Site design and usability improvements.

Comments

@alxndrsn
Copy link
Contributor

It seems that the Targets tab will not display a loading spinner while waiting for data the first time it's loaded. This is very noticeable if you have a very large dataset.
@alxndrsn alxndrsn added the Type: Bug Fix something that isn't working as intended label Feb 26, 2018
garethbowen added a commit that referenced this issue May 3, 2018
@garethbowen
Adds a loading spinner to the targets page
7b1c973 
#4241
@garethbowen garethbowen added UI/UX Site design and usability improvements. Priority: 3 - Low Can be bumped from the release Type: Improvement Make something better and removed Type: Bug Fix something that isn't working as intended labels May 3, 2018
@garethbowen garethbowen mentioned this issue May 3, 2018
Merged
5 tasks
@garethbowen
Copy link
Member

Code review please @alxndrsn

alxndrsn pushed a commit that referenced this issue May 3, 2018
@garethbowen @alxndrsn
Adds a loading spinner to the targets page
d00cc92 
#4241
@alxndrsn alxndrsn removed their assignment May 3, 2018
@ngaruko ngaruko self-assigned this May 3, 2018
@ngaruko
Copy link
Contributor

ngaruko commented May 3, 2018

LGTM

@ngaruko ngaruko closed this as completed May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ngaruko ngaruko

Labels
Priority: 3 - Low Can be bumped from the release Type: Improvement Make something better UI/UX Site design and usability improvements.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alxndrsn @garethbowen @ngaruko