Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms still available after deleting them using medic-conf #5078

Closed
binokaryg opened this issue Dec 6, 2018 · 2 comments
Closed

Forms still available after deleting them using medic-conf #5078

binokaryg opened this issue Dec 6, 2018 · 2 comments
Assignees
Labels
API Affects the API service Priority: 1 - High Blocks the next release. Type: Bug Fix something that isn't working as intended
Projects

Comments

@binokaryg
Copy link
Member

binokaryg commented Dec 6, 2018

The forms deleted using medic-conf are still available and usable from the web app.

Steps to reproduce:

  • Deleted an existing form that was visible in the web app under "New Action":
    medic-conf --url http://admin:<password>@localhost:5988 delete-forms -- report_id

It says:

INFO Starting action: delete-forms…
INFO delete-forms complete.
INFO Deleted form: report_id
  • Checked the form in "New Action", it is still visible and usable.
  • Checked in Medic Mobile administration console - Forms: The form is not there.
  • Checked in couchdb (medic-client/forms): The form is not there.

What should happen:

  • The deleted form should no longer be visible in the web app.

What actually happens:

  • The deleted form was available for use.

Environment:

  • Instance: (demo-cht.dev.medicmobile.org), also replicated in local instance
  • Browser: (Chrome)
  • Client platform: (Windows)
  • App: (webapp, medic-conf)
  • Version: (3.0.0)

Other:
I also tried by reloading the web app several times, logging out and in again.
The form disappeared only after clearing the site data from (Chrome) Developer Tools - Application - Clear storage - Clear site data - Reload

@dianabarsan dianabarsan self-assigned this Dec 6, 2018
@dianabarsan dianabarsan added Type: Bug Fix something that isn't working as intended Priority: 1 - High Blocks the next release. API Affects the API service labels Dec 6, 2018
@garethbowen garethbowen added this to To do in 3.4.0 via automation Dec 9, 2018
@garethbowen
Copy link
Member

@binokaryg Awesome issue! Thanks for providing so much info, it really makes our job easier.

@dianabarsan dianabarsan moved this from To do to In progress in 3.4.0 Dec 10, 2018
garethbowen pushed a commit that referenced this issue Dec 11, 2018
Fixes bug where deletion of forms would not be replicated to offline users.

#5078
@garethbowen garethbowen moved this from In progress to In AT in 3.4.0 Dec 11, 2018
@ngaruko
Copy link
Contributor

ngaruko commented Dec 21, 2018

LGTM.
The deleted form disappeared after page reload. Checked with @binokaryg and we agreed that this is good enough for this issue.
Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Affects the API service Priority: 1 - High Blocks the next release. Type: Bug Fix something that isn't working as intended
Projects
No open projects
3.4.0
  
Done
Development

No branches or pull requests

4 participants