Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language select modal Submit button never enabled #5978

Closed
garethbowen opened this issue Sep 23, 2019 · 3 comments
Closed

Language select modal Submit button never enabled #5978

garethbowen opened this issue Sep 23, 2019 · 3 comments
Assignees
@ngaruko
Labels
Priority: 1 - High Blocks the next release. Type: Bug Fix something that isn't working as intended

Comments

@garethbowen
Copy link
Member

Describe the bug

The Submit button of the language select modal is never enabled.

To Reproduce

  1. Create a brand new user. It's important that they haven't logged in before or you won't see the language dialog.
  2. Log in as the new user.
  3. See the Submit button is disabled, and no matter what you do it won't enable.

Expected behavior

The default language should be selected, and the button should be enabled. You should not be able to deselect the language. If you switch to another language the button stays enabled.

Screenshots
Screenshot from 2019-09-24 09-54-14

Environment

  • Instance: localhost
  • Browser: Chromium
  • Client platform: Ubuntu
  • App: webapp
  • Version: master
@garethbowen garethbowen added Type: Bug Fix something that isn't working as intended Priority: 1 - High Blocks the next release. labels Sep 23, 2019
@garethbowen garethbowen self-assigned this Sep 23, 2019
@garethbowen
Copy link
Member Author

This was caused by this change: d9ae1aa#diff-a4686eb7ba73af65c80b653e33cf0150R9

garethbowen added a commit that referenced this issue Sep 23, 2019
@garethbowen
Enable submit button when language is chosen
2ffb290 
#5978
This was referenced Sep 23, 2019
Merged
Merged
@garethbowen
Copy link
Member Author

Ready for AT in 5978-fix-typo

@ngaruko ngaruko self-assigned this Sep 24, 2019
@ngaruko
Copy link
Contributor

ngaruko commented Sep 24, 2019

LGTM
On master
image

On the branch
image

ngaruko pushed a commit that referenced this issue Sep 24, 2019
@garethbowen @ngaruko
Enable submit button when language is chosen (#5979)
110f304 
#5978
@ngaruko ngaruko closed this as completed Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ngaruko ngaruko

Labels
Priority: 1 - High Blocks the next release. Type: Bug Fix something that isn't working as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garethbowen @ngaruko