Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Namespace if not exist #295

Merged

Conversation

clobrano
Copy link
Contributor

Now that we use our own namespace, it might not exist already when
running bundle-run Makefile target.

Add a new Makefile target to create the Namespace, if it does not exist,
before running bundle-run

Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Now that we use our own namespace, it might not exist already when
running `bundle-run` Makefile target.

Add a new Makefile target to create the Namespace, if it does not exist,
before running `bundle-run`

Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
@slintes
Copy link
Member

slintes commented Feb 14, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 14, 2024
@clobrano clobrano marked this pull request as ready for review February 14, 2024 10:26
@openshift-merge-bot openshift-merge-bot bot merged commit a295bef into medik8s:main Feb 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants