Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Makefile calls to build-bundle-ocp #302

Merged

Conversation

clobrano
Copy link
Contributor

Why we need this PR

In commit b3468b7 "Makefile target to create bundle OCP" the target bundle-build was renamed into bundle-build-ocp, but some occurrences of such target have not been updated to the new name.

Changes made

Whenever bundle-build is used in the Makefile, it is replaced by bundle-build-ocp.

In commit b3468b7 "Makefile target to create bundle OCP" the target
`bundle-build` was renamed into `bundle-build-ocp`, but some
occurrences of such target have not been updated to the new name.

Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
Copy link
Contributor

openshift-ci bot commented Mar 11, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Member

@slintes slintes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now.
When we add OKD, IMHO we should update all relevant targets to have either a -k8s, -okd or -ocp suffix, and revisit all occurences where we call those targets, to avoid any confusion.

Copy link
Contributor

openshift-ci bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clobrano clobrano marked this pull request as ready for review March 11, 2024 15:57
@openshift-ci openshift-ci bot requested review from razo7 and slintes March 11, 2024 15:57
@openshift-merge-bot openshift-merge-bot bot merged commit ff1a2eb into medik8s:main Mar 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants