Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a file-based catalog #311

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

clobrano
Copy link
Contributor

@clobrano clobrano commented Apr 5, 2024

Why we need this PR

Currently NHC's Makefile creates a db-based catalog, which is deprecated

DEPRECATION NOTICE:
Sqlite-based catalogs and their related subcommands are deprecated. Support for
them will be removed in a future release. Please migrate your catalog workflows
to the new file-based catalog format.

Changes made

This change creates a file-based catalog

https://docs.openshift.com/container-platform/4.14/operators/admin/olm-managing-custom-catalogs.html#olm-managing-custom-catalogs-fb

Which issue(s) this PR fixes

https://issues.redhat.com/browse/ECOPROJECT-1948

Test plan

  • create the file-based catalog and push it to my quay.io repository via Makefile
  • create a CatalogSource pointing to the new catalog
  • install FAR via WebUI, verify that everything works

Replace the deprecated db-based catalog with a file-based one.

Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
Copy link
Contributor

openshift-ci bot commented Apr 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 5, 2024
@clobrano
Copy link
Contributor Author

clobrano commented Apr 8, 2024

interesting, it seems kind isn't happy with this change

2024/04/05 17:09:58 render reference "kind-registry:5000/node-healthcheck-operator-bundle:latest": error resolving name for image ref kind-registry:5000/node-healthcheck-operator-bundle:latest: failed to do request: Head "https://kind-registry:5000/v2/node-healthcheck-operator-bundle/manifests/latest": http: server gave HTTP response to HTTPS client

@clobrano
Copy link
Contributor Author

I am testing the k8s-e2e phase, do not merge
/hold

@clobrano clobrano force-pushed the move-to-file-based-catalog-0 branch 2 times, most recently from 8d995a9 to 1b89629 Compare April 16, 2024 14:20
Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant