Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.14] Disable HTTP/2 #102

Closed
wants to merge 5 commits into from
Closed

[release-0.14] Disable HTTP/2 #102

wants to merge 5 commits into from

Conversation

slintes
Copy link
Member

@slintes slintes commented Oct 20, 2023

Mitigates HTTP/2 CVEs

manual backport of #100

razo7 and others added 5 commits October 16, 2023 16:30
@razo7
Update golang.org/x/net
4982dcc 
golang.org/x/net v0.17.0 has fixes for http/2 CVE
@razo7
Update k8s.io/apimachinery@release-1.25
94dc199 
Run 'go get k8s.io/apimachinery@release-1.25' for updating go.mod and fixing http/2 CVE
@razo7
Run make go-verify
c0c6e36 
Add missing and remove unused modules, make vendored copy of dependencies, and verify dependencies have expected content
@openshift-ci
Merge pull request medik8s#97 from razo7/fix-http/2-cve
408d8fe 
[release-0.14]  Fix http/2 CVE
@slintes
Disable HTTP/s on webhook server
12db76e 
Signed-off-by: Marc Sluiter <msluiter@redhat.com>

(cherry picked from commit 3ef4e1b)
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from mshitrit and razo7 October 20, 2023 12:10
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@slintes
Copy link
Member Author

slintes commented Oct 20, 2023

wrong branch...

@slintes slintes closed this Oct 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

@slintes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.12-ci-index 12db76e link true /test 4.12-ci-index
ci/prow/4.14-ci-index 12db76e link true /test 4.14-ci-index
ci/prow/4.15-ci-index 12db76e link true /test 4.15-ci-index
ci/prow/4.13-ci-index 12db76e link true /test 4.13-ci-index

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshitrit mshitrit Awaiting requested review from mshitrit

@razo7 razo7 Awaiting requested review from razo7

Assignees
No one assigned
Labels
approved needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slintes @openshift-merge-robot @razo7