Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine Macros in Makefile #112

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Jan 14, 2024

Redefine OPERATOR_NAME and OPERATOR_NAMESPACE macros in Makefile.
Add mew target, bundle-cleanup, for removing a bundle installed via bundle-run target.

Store opreator name with the word 'operator'
Copy link
Contributor

openshift-ci bot commented Jan 14, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@razo7
Copy link
Member Author

razo7 commented Jan 14, 2024

/test 4.15-openshift-e2e

Copy link
Contributor

openshift-ci bot commented Jan 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@clobrano clobrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment


.PHONY: bundle-cleanup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a comment in PR and commit about this new target?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Store opreator namespace with the the default and recommended namespace
Easily remove bundle installed via bundle-run
@razo7
Copy link
Member Author

razo7 commented Jan 15, 2024

/test 4.15-openshift-e2e

@clobrano
Copy link
Contributor

Nice commits re-organization 👏

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 15, 2024
@razo7 razo7 marked this pull request as ready for review January 15, 2024 11:30
@razo7
Copy link
Member Author

razo7 commented Jan 15, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit db8546f into medik8s:main Jan 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants