-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redefine Macros in Makefile #112
Conversation
Store opreator name with the word 'operator'
Skipping CI for Draft Pull Request. |
/test 4.15-openshift-e2e |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment
|
||
.PHONY: bundle-cleanup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a comment in PR and commit about this new target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Store opreator namespace with the the default and recommended namespace
Easily remove bundle installed via bundle-run
774ce29
to
369473e
Compare
/test 4.15-openshift-e2e |
Nice commits re-organization 👏 /lgtm |
/retest |
Redefine OPERATOR_NAME and OPERATOR_NAMESPACE macros in Makefile.
Add mew target,
bundle-cleanup
, for removing a bundle installed viabundle-run
target.