Test coverage

mediocre · Jul 3, 2019 · e7a184f · e7a184f
1 parent 566178f
commit e7a184f
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 10 deletions.
diff --git a/carriers/usps.js b/carriers/usps.js
@@ -71,20 +71,20 @@ function USPS(options) {
             }
 
             parser.parseString(res.body, function(err, data) {
+                const results = {
+                    events: []
+                };
+
                 if (err) {
                     return callback(err);
                 } else if (data.Error) {
-                    // Invalid credentials
+                    // Invalid credentials or Invalid Tracking Number
                     return callback(new Error(data.Error.Description[0]));
                 } else if (data.TrackResponse.TrackInfo[0].Error) {
-                    // Invalid tracking number
-                    return callback(new Error(data.TrackResponse.TrackInfo[0].Error[0].Description[0]));
+                    // No Tracking Information
+                    return callback(null, results);
                 }
 
-                const results = {
-                    events: []
-                };
-
                 const scanDetailsList = [];
 
                 // TrackSummary[0] exists for every item (with valid tracking number)

diff --git a/test/carriers/usps.js b/test/carriers/usps.js
@@ -83,12 +83,24 @@ describe('USPS', function () {
                 done();
             });
         });
+
+        it('should return an error for a tracking number that contains invalid characters', function (done) {
+            bloodhound.track('12c &^trackf0', 'usps', function (err) {
+                assert(err);
+                done();
+            })
+        })
     });
 
     describe('USPS Tracking', function () {
-        it('should return an error for an invalid tracking number', function (done) {
-            bloodhound.track('An Invalid Tracking Number', 'usps', function (err) {
-                assert(err);
+        it.only('should return an empty result if there is no tracking information available ', function (done) {
+            bloodhound.track('0987654321234567890', 'usps', function (err, actual) {
+                const expected = {
+                    events: []
+                }
+
+                assert.ifError(err);
+                assert.deepStrictEqual(actual, expected);
                 done();
             });
         });
@@ -196,5 +208,11 @@ describe('USPS', function () {
                 done();
             });
         });
+        it('should skip Track Details that do no have time stamps', function (done) {
+            bloodhound.track('9400110200830244685403', 'usps', function (err) {
+                assert.ifError(err);
+                done();
+            });
+        })
     });
 });