Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign-in to graphiql fails if DomainConfiguration is present #4365

Open
rahul1 opened this issue Apr 12, 2024 · 2 comments · Fixed by #4456
Open

Sign-in to graphiql fails if DomainConfiguration is present #4365

rahul1 opened this issue Apr 12, 2024 · 2 comments · Fixed by #4456
Assignees
@codyebberson
Labels
bug Something isn't working
Milestone
June 30, 2024

Comments

@rahul1
Copy link
Member

rahul1 commented Apr 12, 2024

Already in progress - just tracking
@rahul1 rahul1 added the bug Something isn't working label Apr 12, 2024
@rahul1 rahul1 added this to the April 30th, 2024 milestone Apr 12, 2024
@rahul1 rahul1 mentioned this issue Apr 22, 2024
Closed
@codyebberson
Copy link
Member

  1. Need to grab the login query string parameter and pass to <SignInForm> component in graphiql
  2. Need to respect ClientApplication.pkceOptional in the graphiql config

codyebberson added a commit that referenced this issue Apr 23, 2024
@codyebberson
Fixes #4365 - graphiql and external auth providers
59156d6
github-merge-queue bot pushed a commit that referenced this issue Apr 23, 2024
@codyebberson
Fixes #4365 - graphiql and external auth providers (#4439)
c69b9e8 
* Fixes #4365 - graphiql and external auth providers

* Add tests
codyebberson added a commit that referenced this issue Apr 23, 2024
@codyebberson
Revert "Fixes #4365 - graphiql and external auth providers (#4439)"
8eae9d3 
This reverts commit c69b9e8.
medplumbot added a commit that referenced this issue Apr 26, 2024
@medplumbot
Release Version 3.1.4
51133b5 
Note that only admins can invite users (#4428)Add note about restarting server on config change (#4425)
Don't warn on primitive extensions (#4433)
Per-project rate limiter config (#4412)
Adding HL7 Interfacing engine materials (#4430)
deps(formidable): override insecure version (#4437)
Fixes #4365 - graphiql and external auth providers (#4439)
Fixes #3240 - rate-limit-redis persistent rate limit storage (#4435)
Revert "Fixes #4365 - graphiql and external auth providers (#4439)" (#4441)
Link bot docs to vm context doc (#4426)
Increase max db pool connections from 10 to 50 per host (#4447)
[Medplum Provider] Require resource profiles (#4387)
Revert agent serialport (#4453)
fix(agent): align `pkg` target and `node` version used to compile agent (#4451)
Fixes #4444 - update Appointment status constraint (#4446)
@medplumbot medplumbot mentioned this issue Apr 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 26, 2024
@medplumbot
Release Version 3.1.4 (#4456)
f854783 
Note that only admins can invite users (#4428)Add note about restarting server on config change (#4425)
Don't warn on primitive extensions (#4433)
Per-project rate limiter config (#4412)
Adding HL7 Interfacing engine materials (#4430)
deps(formidable): override insecure version (#4437)
Fixes #4365 - graphiql and external auth providers (#4439)
Fixes #3240 - rate-limit-redis persistent rate limit storage (#4435)
Revert "Fixes #4365 - graphiql and external auth providers (#4439)" (#4441)
Link bot docs to vm context doc (#4426)
Increase max db pool connections from 10 to 50 per host (#4447)
[Medplum Provider] Require resource profiles (#4387)
Revert agent serialport (#4453)
fix(agent): align `pkg` target and `node` version used to compile agent (#4451)
Fixes #4444 - update Appointment status constraint (#4446)
@rahul1
Copy link
Member Author

rahul1 commented May 17, 2024

Reopening, since there is work underway to verify this fix on Azure SSO

@rahul1 rahul1 reopened this May 17, 2024
@reshmakh reshmakh modified the milestones: May 31st, 2024, June 30, 2024 Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyebberson codyebberson

Labels
bug Something isn't working
Projects
Medplum Product Roadmap
Status: 🔖 Ready to Start
Milestone
June 30, 2024
Development

Successfully merging a pull request may close this issue.

Release Version 3.1.4 medplum/medplum
3 participants
@codyebberson @rahul1 @reshmakh