Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn on primitive extensions #4433

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Conversation

mattlong
Copy link
Member

The presence of a primitive type extension alongside its related choice-of-type value, e.g. _valueString and valueString was triggering the duplicate choice-of-type property warning when it shouldn't have been.

@mattlong mattlong requested a review from a team as a code owner April 22, 2024 22:23
Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medplum-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 11:11pm
medplum-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 11:11pm
medplum-storybook 🛑 Canceled (Inspect) Apr 22, 2024 11:11pm
medplum-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 11:11pm

@mattlong mattlong enabled auto-merge April 22, 2024 22:28
Copy link

sonarcloud bot commented Apr 22, 2024

@mattlong mattlong added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit 19cfe9e Apr 22, 2024
29 of 32 checks passed
@mattlong mattlong deleted the primitive-extension-validation branch April 22, 2024 22:58
@reshmakh reshmakh added this to the April 30th, 2024 milestone Apr 23, 2024
@reshmakh reshmakh added the fhir-datastore Related to the FHIR datastore, includes API and FHIR operations label Apr 23, 2024
medplumbot added a commit that referenced this pull request Apr 26, 2024
Note that only admins can invite users (#4428)Add note about restarting server on config change (#4425)
Don't warn on primitive extensions (#4433)
Per-project rate limiter config (#4412)
Adding HL7 Interfacing engine materials (#4430)
deps(formidable): override insecure version (#4437)
Fixes #4365 - graphiql and external auth providers (#4439)
Fixes #3240 - rate-limit-redis persistent rate limit storage (#4435)
Revert "Fixes #4365 - graphiql and external auth providers (#4439)" (#4441)
Link bot docs to vm context doc (#4426)
Increase max db pool connections from 10 to 50 per host (#4447)
[Medplum Provider] Require resource profiles (#4387)
Revert agent serialport (#4453)
fix(agent): align `pkg` target and `node` version used to compile agent (#4451)
Fixes #4444 - update Appointment status constraint (#4446)
github-merge-queue bot pushed a commit that referenced this pull request Apr 26, 2024
Note that only admins can invite users (#4428)Add note about restarting server on config change (#4425)
Don't warn on primitive extensions (#4433)
Per-project rate limiter config (#4412)
Adding HL7 Interfacing engine materials (#4430)
deps(formidable): override insecure version (#4437)
Fixes #4365 - graphiql and external auth providers (#4439)
Fixes #3240 - rate-limit-redis persistent rate limit storage (#4435)
Revert "Fixes #4365 - graphiql and external auth providers (#4439)" (#4441)
Link bot docs to vm context doc (#4426)
Increase max db pool connections from 10 to 50 per host (#4447)
[Medplum Provider] Require resource profiles (#4387)
Revert agent serialport (#4453)
fix(agent): align `pkg` target and `node` version used to compile agent (#4451)
Fixes #4444 - update Appointment status constraint (#4446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fhir-datastore Related to the FHIR datastore, includes API and FHIR operations
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants