Use nullish coalescing operator in HomePage.tsx #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
Kudos, SonarCloud Quality Gate passed! |
codyebberson
approved these changes
Jul 9, 2023
reshmakh
added
the
medplum-app
Merged
codyebberson
added a commit
that referenced
this pull request
Jul 13, 2023
Use eslint-config in examples (#2456) Add bundle to resource array in MedplumClient (#2445) Add server config for logLevel (#2437) Allow `/email` path in CORS (#2455) Add clientId as optional prop to RegisterForm (#2452) Instructions on setting up new patient registration (#2453) Enable sourcemaps in server docker image (#2449) Automatically restart redis docker container on local dev (#2446) Fixes #2439 - clarify node 18+ required (#2442) Fix json bug in access controls docs (#2440) Use user repo in project admin tools (#2435) Preliminary article on auth integration patterns (#2422) Move medplum-demo-bots to /examples (#2403) Fixes #2431 - handle client_id in /auth/newuser (#2434) Fix localStorage infinite loop bug (#2436) Change SearchControl to default to accurate (#2432) Updated title (#2433) Add DocumentReference resource type to ServiceRequest timeline (#2428) Added jwt bearer token auth to MedplumClient (#2408) Update packages/core/src/typeschema/validation.test.ts (#2430) Create sweep.yaml config file (#2427) Update bot-basics.md (#2424) Adding tests to confirm hidden fields behavior (#2425) Fix validation log condition (#2421) Clarify Mutations documentaiton (#2417) Constraint validation (#2321) Document basic functionality of the Medplum App (#2405) Fix code complexity warning in search param details (#2415) Ignore graphiql in sonar analysis (#2414) Fixed more sonar warnings (#2416) Validate Medplum resource profiles (#2404) Update manual mock to use aws-sdk-client-mock (#2407) Fix sonar code smells (#2413) Update packages/app/src/HomePage.tsx (#2412) Update packages/app/src/FormPage.tsx (#2411) Updating broken links found during demo (#2391) Fixes #2396 - block reset password with external auth (#2399) Added docs on $resend operation (#2394) Updated homepage (#2243) Add `~` to SearchControl count to indicate estimated counts (#2380) Add Environment Variable Config Support (#2378) Add merge group CI triggers (#2393) Fixes regression in string array filters (#2392) Perf improvement to getTypedPropertyValue (#2389) Fix merge conflict in validation test (#2390) Cut over to new validation logic (#2382) Add test for profile walking into base type schema (#2388) Adding documentation and examples for CLI optional params to connect to other fhir servers (#2303) Update client-sesv2 manual mock to use aws-sdk-client-mock (#2381) #1314 Add an API Collection for Postman, as well as an env template a… (#2325) Document `_total` search param (#2379) Fixes #2374 - updated jest babel config (#2375) Implement slice validation (#2337) Fix sonar warnings in repo.ts and search.ts (#2373) Fixed build break (#2372) Split repo.ts and search.ts (#2361) Implement Alphabetical Sorting Using localeCompare (#2365) Update lib-storage.ts manual mock to use aws-sdk-client-mock (#2358) Fixes #2052 - Config option to save audit events (#2357) Fixes #2304 - ProjectMembership access-policy search param (#2360) Fixes #2333 - added $versions operation (#2359) ImpliesAtom (#2352) Update client-lambda manual mock to use aws-sdk-client-mock (#2347) Deploy sourcemaps (#2356) Fixes #2354 - always use normalizeOperationOutcome (#2355) Fixes #2350 - estimated count filtering on human name (#2351) Dependency upgrades (#2348) Fixes #2343: Update project operation $expunge everything to use AsyncJob (#2345) update CLI docs on bulk target-directory (#2344) Fixes #2311 - better expression parsing in getSearchParameterDetails (#2324)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
Use eslint-config in examples (#2456) Add bundle to resource array in MedplumClient (#2445) Add server config for logLevel (#2437) Allow `/email` path in CORS (#2455) Add clientId as optional prop to RegisterForm (#2452) Instructions on setting up new patient registration (#2453) Enable sourcemaps in server docker image (#2449) Automatically restart redis docker container on local dev (#2446) Fixes #2439 - clarify node 18+ required (#2442) Fix json bug in access controls docs (#2440) Use user repo in project admin tools (#2435) Preliminary article on auth integration patterns (#2422) Move medplum-demo-bots to /examples (#2403) Fixes #2431 - handle client_id in /auth/newuser (#2434) Fix localStorage infinite loop bug (#2436) Change SearchControl to default to accurate (#2432) Updated title (#2433) Add DocumentReference resource type to ServiceRequest timeline (#2428) Added jwt bearer token auth to MedplumClient (#2408) Update packages/core/src/typeschema/validation.test.ts (#2430) Create sweep.yaml config file (#2427) Update bot-basics.md (#2424) Adding tests to confirm hidden fields behavior (#2425) Fix validation log condition (#2421) Clarify Mutations documentaiton (#2417) Constraint validation (#2321) Document basic functionality of the Medplum App (#2405) Fix code complexity warning in search param details (#2415) Ignore graphiql in sonar analysis (#2414) Fixed more sonar warnings (#2416) Validate Medplum resource profiles (#2404) Update manual mock to use aws-sdk-client-mock (#2407) Fix sonar code smells (#2413) Update packages/app/src/HomePage.tsx (#2412) Update packages/app/src/FormPage.tsx (#2411) Updating broken links found during demo (#2391) Fixes #2396 - block reset password with external auth (#2399) Added docs on $resend operation (#2394) Updated homepage (#2243) Add `~` to SearchControl count to indicate estimated counts (#2380) Add Environment Variable Config Support (#2378) Add merge group CI triggers (#2393) Fixes regression in string array filters (#2392) Perf improvement to getTypedPropertyValue (#2389) Fix merge conflict in validation test (#2390) Cut over to new validation logic (#2382) Add test for profile walking into base type schema (#2388) Adding documentation and examples for CLI optional params to connect to other fhir servers (#2303) Update client-sesv2 manual mock to use aws-sdk-client-mock (#2381) #1314 Add an API Collection for Postman, as well as an env template a… (#2325) Document `_total` search param (#2379) Fixes #2374 - updated jest babel config (#2375) Implement slice validation (#2337) Fix sonar warnings in repo.ts and search.ts (#2373) Fixed build break (#2372) Split repo.ts and search.ts (#2361) Implement Alphabetical Sorting Using localeCompare (#2365) Update lib-storage.ts manual mock to use aws-sdk-client-mock (#2358) Fixes #2052 - Config option to save audit events (#2357) Fixes #2304 - ProjectMembership access-policy search param (#2360) Fixes #2333 - added $versions operation (#2359) ImpliesAtom (#2352) Update client-lambda manual mock to use aws-sdk-client-mock (#2347) Deploy sourcemaps (#2356) Fixes #2354 - always use normalizeOperationOutcome (#2355) Fixes #2350 - estimated count filtering on human name (#2351) Dependency upgrades (#2348) Fixes #2343: Update project operation $expunge everything to use AsyncJob (#2345) update CLI docs on bulk target-directory (#2344) Fixes #2311 - better expression parsing in getSearchParameterDetails (#2324)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #2410. The nullish coalescing operator (??) is used in the file
packages/app/src/HomePage.tsxon line 141 to provide a default value when dealing with null or undefined values. This operator is safer and shorter than using logical OR expressions or explicitly testing against null or undefined.The specific change made was to replace the logical OR operator (||) with the nullish coalescing operator (??) on line 141. This change should not affect the overall functionality of the code.
Fixes #2410.
To checkout this PR branch, run the following command in your terminal: