Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ElementDefinition.contentReference in deep nested backbone element #2868

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

codyebberson
Copy link
Member

Discovered while working on #2859

StructureMap.group.rule.rule was incorrectly added as a field of StructureMap rather than StructureMapGroupRule because it was 3 contexts deep, and we only supported 2.

This fix supports any level of context nesting.

@codyebberson codyebberson requested a review from a team as a code owner September 19, 2023 00:21
@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medplum-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 5:51pm
medplum-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 5:51pm

@coveralls
Copy link

Coverage Status

coverage: 94.122% (-0.001%) from 94.123% when pulling 21796ee on cody-deep-nested-content-reference into 4b0b34a on main.

@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codyebberson codyebberson added this pull request to the merge queue Sep 19, 2023
Merged via the queue into main with commit e32a8ac Sep 19, 2023
12 checks passed
@codyebberson codyebberson deleted the cody-deep-nested-content-reference branch September 19, 2023 18:47
codyebberson added a commit that referenced this pull request Sep 27, 2023
Fixes #2901 - cli command to update s3 bucket policies (#2924)
Bot cli fixes (#2935)
Dynamically move items in QuestionnaireBuilder (#2883)
publish changes (#2927)
Update contributing docs (#2897)
Fixes #2898 - export CDK types (#2905)
Update sweep.yaml (#2920)
Split tsquery handling by language config (#2885)
Add stack traces back to error logs (#2918)
Fixes #2899 - agent push (#2900)
Add request IDs to error responses (#2907)
Create documentation for the Apps Tab (#2873)
Clarify that paginated search requires a _sort for consistency (#2913)
Added docs on the "Communication Lifecycle" (#2912)
Bump graphql from 16.8.0 to 16.8.1 (#2903)
Fixes #2891k - ID capitalization (#2902)
Add Value Set Autocomplete to Kitchen Sink (#2896)
Added reference resolution to  PATCH batch entries (#2884)
Fixes #2876 - CDK creates awsRegion parameter (#2879)
Bind async callbacks to context local storage (#2875)
Clarification on per-server vs. per-project users (#2881)
Fixes #2847 - Create new resources from JSON input (#2870)
Fixes ElementDefinition.contentReference in deep nested backbone element (#2868)
Bind AsyncLocalStorage to cursor callbacks (#2874)
Use getElementDefinitionTypeName (#2869)
Fix bug on page sequence input changes  (#2865)
Updating SOC2 report link to 2023 version (#2872)
Update Patient Dedupe Docs (#2760)
Fix CLI docs headings (#2867)
Monitoring bots documentation (#2782)
Updating bots based on feedback and correcting for use of deprecated fields (#2866)
Remove unnecessary generics (#2864)
Create docs for promoting a user to admin (#2757)
Fixes #2792 - multiple patient compartments in resource (#2862)
Fix 'sign-in' vs 'sign in' in invite email (#2861)
Fixes #2796 - copy binary content in project clone (#2858)
Dependency upgrades (#2857)
codyebberson added a commit that referenced this pull request Sep 28, 2023
Fixes #2901 - cli command to update s3 bucket policies (#2924)
Bot cli fixes (#2935)
Dynamically move items in QuestionnaireBuilder (#2883)
publish changes (#2927)
Update contributing docs (#2897)
Fixes #2898 - export CDK types (#2905)
Update sweep.yaml (#2920)
Split tsquery handling by language config (#2885)
Add stack traces back to error logs (#2918)
Fixes #2899 - agent push (#2900)
Add request IDs to error responses (#2907)
Create documentation for the Apps Tab (#2873)
Clarify that paginated search requires a _sort for consistency (#2913)
Added docs on the "Communication Lifecycle" (#2912)
Bump graphql from 16.8.0 to 16.8.1 (#2903)
Fixes #2891k - ID capitalization (#2902)
Add Value Set Autocomplete to Kitchen Sink (#2896)
Added reference resolution to  PATCH batch entries (#2884)
Fixes #2876 - CDK creates awsRegion parameter (#2879)
Bind async callbacks to context local storage (#2875)
Clarification on per-server vs. per-project users (#2881)
Fixes #2847 - Create new resources from JSON input (#2870)
Fixes ElementDefinition.contentReference in deep nested backbone element (#2868)
Bind AsyncLocalStorage to cursor callbacks (#2874)
Use getElementDefinitionTypeName (#2869)
Fix bug on page sequence input changes  (#2865)
Updating SOC2 report link to 2023 version (#2872)
Update Patient Dedupe Docs (#2760)
Fix CLI docs headings (#2867)
Monitoring bots documentation (#2782)
Updating bots based on feedback and correcting for use of deprecated fields (#2866)
Remove unnecessary generics (#2864)
Create docs for promoting a user to admin (#2757)
Fixes #2792 - multiple patient compartments in resource (#2862)
Fix 'sign-in' vs 'sign in' in invite email (#2861)
Fixes #2796 - copy binary content in project clone (#2858)
Dependency upgrades (#2857)
github-merge-queue bot pushed a commit that referenced this pull request Sep 28, 2023
Fixes #2901 - cli command to update s3 bucket policies (#2924)
Bot cli fixes (#2935)
Dynamically move items in QuestionnaireBuilder (#2883)
publish changes (#2927)
Update contributing docs (#2897)
Fixes #2898 - export CDK types (#2905)
Update sweep.yaml (#2920)
Split tsquery handling by language config (#2885)
Add stack traces back to error logs (#2918)
Fixes #2899 - agent push (#2900)
Add request IDs to error responses (#2907)
Create documentation for the Apps Tab (#2873)
Clarify that paginated search requires a _sort for consistency (#2913)
Added docs on the "Communication Lifecycle" (#2912)
Bump graphql from 16.8.0 to 16.8.1 (#2903)
Fixes #2891k - ID capitalization (#2902)
Add Value Set Autocomplete to Kitchen Sink (#2896)
Added reference resolution to  PATCH batch entries (#2884)
Fixes #2876 - CDK creates awsRegion parameter (#2879)
Bind async callbacks to context local storage (#2875)
Clarification on per-server vs. per-project users (#2881)
Fixes #2847 - Create new resources from JSON input (#2870)
Fixes ElementDefinition.contentReference in deep nested backbone element (#2868)
Bind AsyncLocalStorage to cursor callbacks (#2874)
Use getElementDefinitionTypeName (#2869)
Fix bug on page sequence input changes  (#2865)
Updating SOC2 report link to 2023 version (#2872)
Update Patient Dedupe Docs (#2760)
Fix CLI docs headings (#2867)
Monitoring bots documentation (#2782)
Updating bots based on feedback and correcting for use of deprecated fields (#2866)
Remove unnecessary generics (#2864)
Create docs for promoting a user to admin (#2757)
Fixes #2792 - multiple patient compartments in resource (#2862)
Fix 'sign-in' vs 'sign in' in invite email (#2861)
Fixes #2796 - copy binary content in project clone (#2858)
Dependency upgrades (#2857)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants