Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2891k - ID capitalization #2902

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Fixes #2891k - ID capitalization #2902

merged 2 commits into from
Sep 22, 2023

Conversation

capitalpb
Copy link
Contributor

@capitalpb capitalpb commented Sep 21, 2023

Looks like the buildFieldNameString is checking for id but not Id as well. Added this check into the method.

@capitalpb capitalpb requested a review from a team as a code owner September 21, 2023 18:37
@vercel
Copy link

vercel bot commented Sep 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medplum-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 11:36pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
medplum-www ⬜️ Ignored (Inspect) Visit Preview Sep 21, 2023 11:36pm

@vercel
Copy link

vercel bot commented Sep 21, 2023

@capitalpb is attempting to deploy a commit to the Medplum Team on Vercel.

A member of the Team first needs to authorize it.

@codyebberson codyebberson changed the title fixes #2891 Fixes #2891k - ID capitalization Sep 22, 2023
Copy link
Member

@codyebberson codyebberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @capitalpb !

@codyebberson codyebberson added this pull request to the merge queue Sep 22, 2023
Merged via the queue into medplum:main with commit d7ef54a Sep 22, 2023
10 checks passed
codyebberson added a commit that referenced this pull request Sep 27, 2023
Fixes #2901 - cli command to update s3 bucket policies (#2924)
Bot cli fixes (#2935)
Dynamically move items in QuestionnaireBuilder (#2883)
publish changes (#2927)
Update contributing docs (#2897)
Fixes #2898 - export CDK types (#2905)
Update sweep.yaml (#2920)
Split tsquery handling by language config (#2885)
Add stack traces back to error logs (#2918)
Fixes #2899 - agent push (#2900)
Add request IDs to error responses (#2907)
Create documentation for the Apps Tab (#2873)
Clarify that paginated search requires a _sort for consistency (#2913)
Added docs on the "Communication Lifecycle" (#2912)
Bump graphql from 16.8.0 to 16.8.1 (#2903)
Fixes #2891k - ID capitalization (#2902)
Add Value Set Autocomplete to Kitchen Sink (#2896)
Added reference resolution to  PATCH batch entries (#2884)
Fixes #2876 - CDK creates awsRegion parameter (#2879)
Bind async callbacks to context local storage (#2875)
Clarification on per-server vs. per-project users (#2881)
Fixes #2847 - Create new resources from JSON input (#2870)
Fixes ElementDefinition.contentReference in deep nested backbone element (#2868)
Bind AsyncLocalStorage to cursor callbacks (#2874)
Use getElementDefinitionTypeName (#2869)
Fix bug on page sequence input changes  (#2865)
Updating SOC2 report link to 2023 version (#2872)
Update Patient Dedupe Docs (#2760)
Fix CLI docs headings (#2867)
Monitoring bots documentation (#2782)
Updating bots based on feedback and correcting for use of deprecated fields (#2866)
Remove unnecessary generics (#2864)
Create docs for promoting a user to admin (#2757)
Fixes #2792 - multiple patient compartments in resource (#2862)
Fix 'sign-in' vs 'sign in' in invite email (#2861)
Fixes #2796 - copy binary content in project clone (#2858)
Dependency upgrades (#2857)
codyebberson added a commit that referenced this pull request Sep 28, 2023
Fixes #2901 - cli command to update s3 bucket policies (#2924)
Bot cli fixes (#2935)
Dynamically move items in QuestionnaireBuilder (#2883)
publish changes (#2927)
Update contributing docs (#2897)
Fixes #2898 - export CDK types (#2905)
Update sweep.yaml (#2920)
Split tsquery handling by language config (#2885)
Add stack traces back to error logs (#2918)
Fixes #2899 - agent push (#2900)
Add request IDs to error responses (#2907)
Create documentation for the Apps Tab (#2873)
Clarify that paginated search requires a _sort for consistency (#2913)
Added docs on the "Communication Lifecycle" (#2912)
Bump graphql from 16.8.0 to 16.8.1 (#2903)
Fixes #2891k - ID capitalization (#2902)
Add Value Set Autocomplete to Kitchen Sink (#2896)
Added reference resolution to  PATCH batch entries (#2884)
Fixes #2876 - CDK creates awsRegion parameter (#2879)
Bind async callbacks to context local storage (#2875)
Clarification on per-server vs. per-project users (#2881)
Fixes #2847 - Create new resources from JSON input (#2870)
Fixes ElementDefinition.contentReference in deep nested backbone element (#2868)
Bind AsyncLocalStorage to cursor callbacks (#2874)
Use getElementDefinitionTypeName (#2869)
Fix bug on page sequence input changes  (#2865)
Updating SOC2 report link to 2023 version (#2872)
Update Patient Dedupe Docs (#2760)
Fix CLI docs headings (#2867)
Monitoring bots documentation (#2782)
Updating bots based on feedback and correcting for use of deprecated fields (#2866)
Remove unnecessary generics (#2864)
Create docs for promoting a user to admin (#2757)
Fixes #2792 - multiple patient compartments in resource (#2862)
Fix 'sign-in' vs 'sign in' in invite email (#2861)
Fixes #2796 - copy binary content in project clone (#2858)
Dependency upgrades (#2857)
github-merge-queue bot pushed a commit that referenced this pull request Sep 28, 2023
Fixes #2901 - cli command to update s3 bucket policies (#2924)
Bot cli fixes (#2935)
Dynamically move items in QuestionnaireBuilder (#2883)
publish changes (#2927)
Update contributing docs (#2897)
Fixes #2898 - export CDK types (#2905)
Update sweep.yaml (#2920)
Split tsquery handling by language config (#2885)
Add stack traces back to error logs (#2918)
Fixes #2899 - agent push (#2900)
Add request IDs to error responses (#2907)
Create documentation for the Apps Tab (#2873)
Clarify that paginated search requires a _sort for consistency (#2913)
Added docs on the "Communication Lifecycle" (#2912)
Bump graphql from 16.8.0 to 16.8.1 (#2903)
Fixes #2891k - ID capitalization (#2902)
Add Value Set Autocomplete to Kitchen Sink (#2896)
Added reference resolution to  PATCH batch entries (#2884)
Fixes #2876 - CDK creates awsRegion parameter (#2879)
Bind async callbacks to context local storage (#2875)
Clarification on per-server vs. per-project users (#2881)
Fixes #2847 - Create new resources from JSON input (#2870)
Fixes ElementDefinition.contentReference in deep nested backbone element (#2868)
Bind AsyncLocalStorage to cursor callbacks (#2874)
Use getElementDefinitionTypeName (#2869)
Fix bug on page sequence input changes  (#2865)
Updating SOC2 report link to 2023 version (#2872)
Update Patient Dedupe Docs (#2760)
Fix CLI docs headings (#2867)
Monitoring bots documentation (#2782)
Updating bots based on feedback and correcting for use of deprecated fields (#2866)
Remove unnecessary generics (#2864)
Create docs for promoting a user to admin (#2757)
Fixes #2792 - multiple patient compartments in resource (#2862)
Fix 'sign-in' vs 'sign in' in invite email (#2861)
Fixes #2796 - copy binary content in project clone (#2858)
Dependency upgrades (#2857)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants