Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

fix: several issues related to order transfer and null addresses #876

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

kasperkristensen
Copy link
Contributor

What

  • Fixes an issue where the order transfer modal would throw an error if the current customer has no name and the order has no billing address.
  • Fixes an issue where edit shipping and billing address options were missing from the menu if the order has no addresses.
  • Fixes an issue where the customer name would not update in the orders table after a successful ownership transfer.

Fixes CORE-1048

@vercel
Copy link

vercel bot commented Jan 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 31, 2023 at 4:20PM (UTC)
typeormv3 ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 31, 2023 at 4:20PM (UTC)

@kasperkristensen kasperkristensen changed the title fix several issues related to order transfer and null addresses fix: several issues related to order transfer and null addresses Jan 31, 2023
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally - nice one💪

Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasperkristensen Just tested it and it all works well on my end! Just one thing though: when editing a billing address that is null, I fill out the form normally and hit save, get a notification that the address is saved, but the address is actually still not set. Maybe because there's no address ID being passed? For reference, here's the payload:

{
    "first_name": "asafas",
    "last_name": "safas",
    "phone": null,
    "company": null,
    "address_1": "asfsa",
    "address_2": null,
    "city": "safas",
    "province": null,
    "country_code": "se",
    "postal_code": "3243"
}

Edit: added a screen recording in case it's helpful

Screen.Recording.2023-01-31.at.6.25.20.PM.mov

@olivermrbl
Copy link
Contributor

@shahednasser Nice catch. I can reproduce with an integration test, so I'll create an issue for it :)

@olivermrbl
Copy link
Contributor

Solved in #3153

@olivermrbl olivermrbl merged commit b192245 into develop Jan 31, 2023
@olivermrbl olivermrbl deleted the fix/order-transfer-and-null-addresses branch January 31, 2023 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants