feat(medusa): Convert ShippingProfileService to TypeScript (#1963)

medusajs · Aug 8, 2022 · 152934f · 152934f
1 parent 40ae535
commit 152934f
Show file tree

Hide file tree

Showing 8 changed files with 519 additions and 512 deletions.
diff --git a/.changeset/proud-papayas-enjoy.md b/.changeset/proud-papayas-enjoy.md
@@ -0,0 +1,5 @@
+---
+"@medusajs/medusa": patch
+---
+
+Convert ShippingProfileService to TypeScript
diff --git a/packages/medusa/src/api/routes/admin/shipping-profiles/index.ts b/packages/medusa/src/api/routes/admin/shipping-profiles/index.ts
@@ -31,7 +31,7 @@ export default (app) => {
   return app
 }
 
-export const defaultAdminShippingProfilesFields = [
+export const defaultAdminShippingProfilesFields: (keyof ShippingProfile)[] = [
   "id",
   "name",
   "type",
@@ -43,10 +43,8 @@ export const defaultAdminShippingProfilesFields = [
 
 export type AdminDeleteShippingProfileRes = DeleteResponse
 
-export const defaultAdminShippingProfilesRelations = [
-  "products",
-  "shipping_options",
-]
+export const defaultAdminShippingProfilesRelations: (keyof ShippingProfile)[] =
+  ["products", "shipping_options"]
 
 export type AdminShippingProfilesRes = {
   shipping_profile: ShippingProfile

diff --git a/packages/medusa/src/services/__tests__/shipping-profile.js b/packages/medusa/src/services/__tests__/shipping-profile.js
@@ -29,21 +29,21 @@ describe("ShippingProfileService", () => {
 
   describe("update", () => {
     const profRepo = MockRepository({
-      findOne: q => {
+      findOne: (q) => {
         return Promise.resolve({ id: q.where.id })
       },
     })
 
     const productService = {
       update: jest.fn(),
-      withTransaction: function() {
+      withTransaction: function () {
         return this
       },
     }
 
     const shippingOptionService = {
       update: jest.fn(),
-      withTransaction: function() {
+      withTransaction: function () {
         return this
       },
     }
@@ -98,7 +98,7 @@ describe("ShippingProfileService", () => {
 
   describe("delete", () => {
     const profRepo = MockRepository({
-      findOne: q => {
+      findOne: (q) => {
         return Promise.resolve({ id: q.where.id })
       },
     })
@@ -126,7 +126,7 @@ describe("ShippingProfileService", () => {
 
     const productService = {
       update: jest.fn(),
-      withTransaction: function() {
+      withTransaction: function () {
         return this
       },
     }
@@ -156,7 +156,7 @@ describe("ShippingProfileService", () => {
 
   describe("fetchCartOptions", () => {
     const profRepo = MockRepository({
-      find: q => {
+      find: (q) => {
         switch (q.where.id) {
           default:
             return Promise.resolve([
@@ -188,8 +188,8 @@ describe("ShippingProfileService", () => {
           },
         ])
       }),
-      validateCartOption: jest.fn().mockImplementation(s => s),
-      withTransaction: function() {
+      validateCartOption: jest.fn().mockImplementation((s) => s),
+      withTransaction: function () {
         return this
       },
     }
@@ -301,7 +301,7 @@ describe("ShippingProfileService", () => {
 
     const shippingOptionService = {
       update: jest.fn(),
-      withTransaction: function() {
+      withTransaction: function () {
         return this
       },
     }