Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa): Convert ShippingProfileService to TypeScript #1963

Merged

Conversation

pKorsholm
Copy link
Contributor

@pKorsholm pKorsholm commented Aug 2, 2022

What

  • convert shipping profile service to typescript

Fixes CORE-359

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2022

🦋 Changeset detected

Latest commit: 2455136

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pKorsholm pKorsholm force-pushed the feat/convert-shipping-profile-service-to-typescript branch from cd4761e to cf27efc Compare August 3, 2022 06:59
@pKorsholm pKorsholm marked this pull request as ready for review August 3, 2022 07:09
@pKorsholm pKorsholm requested a review from a team as a code owner August 3, 2022 07:09
@pKorsholm pKorsholm force-pushed the feat/convert-shipping-profile-service-to-typescript branch from 7d28f5f to 717d0cb Compare August 4, 2022 02:49
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - with some non-blocking comments. Feel free to fix them if-minor

packages/medusa/src/services/shipping-profile.ts Outdated Show resolved Hide resolved
@olivermrbl olivermrbl changed the title Feat/convert shipping profile service to typescript feat(medusa): Convert ShippingProfileService to TypeScript Aug 8, 2022
@olivermrbl olivermrbl merged commit 152934f into develop Aug 8, 2022
@olivermrbl olivermrbl deleted the feat/convert-shipping-profile-service-to-typescript branch August 8, 2022 14:51
carlos-r-l-rodrigues pushed a commit that referenced this pull request Aug 22, 2022
…1992)

feat(medusa): Convert CollectionService to TypeScript (#1976)

feat(medusa): Convert OauthService to TypeScript (#1983)

feat(medusa-js): Add Collection batch (remove, add) endpoints (#1958)

feat(medusa-react): Add Collection batch (remove, add) endpoints (#1959)

feat(medusa-payment-stripe): Add support for Przelewy24 and Blik (#1982)

feat(medusa): Convert ShippingProfileService to TypeScript (#1963)

feat(medusa): Use transactions in CartCompletionStrategy (#1968)

feat(medusa): Convert IdempotencyKeyService to TypeScript (#1995)

* feat(medusa): Migrate the idempotency key service to ts + fix

* feat(medusa): Finalise idempotency migration

* Create late-owls-pump.md

* feat(medusa): Polish

* feat(medusa): Add case to the error handler

* feat(medusa): Add case to the error handler

Co-authored-by: olivermrbl <oliver@mrbltech.com>

feat(medusa,medusa-telemetry): Add telemetry on feature flags (#2017)

chore(medusa): Feature flag loader simplify, deduplicate and increase readability (#2025)

feat(medusa:) Convert PaymentProvider + PaymentProviderInterface to TS +  (#1773)

* feat(payments): Refactor core Payment related

* fix(medusa): typings

* test(unit): fix suite

* test(unit): fix suite

* feat(medusa): Improve payment provider container typings

* fix(medusa): typings

* styles(medusa): renove comments

* feat(medusa): cleanup

* feat(medusa): Add uniq constraint on payment session and idem key on create-payment-session end point

* fix(medusa): migration

* fix(medusa): create payment session

* feat(medusa): cleanup

feat(medusa): Refactor undefined check into a single util (#2024)

chore(medusa): Remove intepestive services re instanciation in loop (#2036)

* chore(medusa): Renove intepestive services re instanciation in loop

* test(medusa): Fix missing deps

* fix(medusa): Missing await

feat(medusa): Simplify the transaction base service (#2007)

**What**
Simplify the transaction base service.

**How**

In fact, it does not need to be template and reduce the extensibility as the type is internally enforce. Now, the type is deduced by this which can be any derived class.

fix(medusa): join tracking links to all fulfillments in admin/orders (#2045)

Fixes #2042

feat(medusa): Implement the SC migration scripts (#2037)

**What**
Migrate the existing products to the default sales channel

FIXES CORE-434

fix(medusa): Complete cart with 100% discount (#2032)

**What**
Naive fix to allow carts with 100% discount to be completed.

**Why**
Discount total is wrongly calculated if `items` and `items.adjustments` is not included in relations upon retrieving the cart.

**Thought**
This is yet another example of why we need to rethink and refactor totals computation to not depend on what is provided by the user.

fix(medusa-payment-stripe): Add item adjustments relation in CartSubcriber (#2052)

added upgrade guide for v1.3.6

Revert "added upgrade guide for v1.3.6"

This reverts commit 9c3c8cb.

feat(medusa): Migrate Return service to ts (#1926)

feat(medusa): Add Mongolian currency tugrug (#2067)

tests(integration-tests): Allow null updates in discounts (#1299)

feat(medusa): Filtering Customer Orders (#975)

feat(medusa-js): Add deleteSession endpoint (#1234)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants