Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Popover z-index in Edit Variant modal #8158

Closed
Dominic-Preap opened this issue Jul 17, 2024 · 6 comments
Closed

Incorrect Popover z-index in Edit Variant modal #8158

Dominic-Preap opened this issue Jul 17, 2024 · 6 comments

Comments

@Dominic-Preap
Copy link

Dominic-Preap commented Jul 17, 2024

Bug report

Describe the bug

Popover of Edit Variant is behind number input.

System information

Medusa version (including plugins): @medusajs/admin": "^7.1.14"
Node.js version: 20.9.0
Database: Postgresql
Operating system: Windows 10
Browser (if relevant): Chrome

Steps to reproduce the behavior

  1. Go to Product detail
  2. Click Edit Variant in Variant section
  3. Click '...' for Edit Variant to see

Expected behavior

Popover should be in front of input.

Screenshots

image

Code snippets

N/A

Additional context

N/A

@srindom
Copy link
Collaborator

srindom commented Jul 17, 2024

Thanks for opening this issue @Dominic-Preap - would you be up for working on a PR to fix this?

@Dominic-Preap
Copy link
Author

@srindom sure, I'll check contribution guide and make a PR.

@srindom
Copy link
Collaborator

srindom commented Jul 22, 2024

@Dominic-Preap - how did it go with getting started on this? Happy to help if you are bumping into challenges?

@Dominic-Preap
Copy link
Author

Dominic-Preap commented Jul 22, 2024 via email

@adevinwild
Copy link
Contributor

Hey!
I had a little bit of time to fix it, It should be ok now 🙌

@kasperkristensen
Copy link
Contributor

Fixed by @adevinwild in #8358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants